App icon indicating copy to clipboard operation
App copied to clipboard

[LOW] [Splits] [$500] Split bill – Receipt missing details when create a Split bill with 2 new users

Open lanitochka17 opened this issue 1 year ago • 49 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.37-2 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4282722 Email or phone of affected tester (no customers): [email protected] Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Login
  3. Click on the FAB button > Request money
  4. On the scan option, upload a digital receipt that will not fail the scan
  5. On the participant selection list, select 2 other participants that you don't have a group created already
  6. Continue to the final review page
  7. Enter a description and click save button
  8. Wait when Smartscan is complete
  9. Click on the split preview

Expected Result:

The amount and merchant fields are updated

Actual Result:

Red dot and Receipt missing details message appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/0b629182-d25d-4f80-832f-e3f54519188e

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01927251e8dbd3f4a1
  • Upwork Job ID: 1754917730756308992
  • Last Price Increase: 2024-03-23
  • Automatic offers:
    • akinwale | Reviewer | 0

lanitochka17 avatar Feb 06 '24 17:02 lanitochka17

Job added to Upwork: https://www.upwork.com/jobs/~01927251e8dbd3f4a1

melvin-bot[bot] avatar Feb 06 '24 17:02 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

melvin-bot[bot] avatar Feb 06 '24 17:02 melvin-bot[bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] avatar Feb 06 '24 17:02 melvin-bot[bot]

Proposal

Please re-state the problem that we are trying to solve in this issue. The problem arises from the receipt scan not recognizing or correctly assigning the "amount" from a receipt image uploaded for splitting expenses, leading to transactions displaying a "Receipt missing details" message.

What is the root cause of that problem? The root cause of the problem appears to be a bug within the SmartScan's data extraction process. Specifically, identifying and parsing the amount from the uploaded receipt images.

What changes do you think we should make in order to solve the problem?

Refine TransactionUtils.ts:

Update the hasMissingSmartscanFields function to more accurately identify missing or incorrectly scanned data fields. This function checks if the transaction has missing required fields, which directly impacts the error state in the UI.

function hasMissingSmartscanFields(transaction) { return transaction && hasReceipt(transaction) && !isDistanceRequest(transaction) && !isReceiptBeingScanned(transaction) && areRequiredFieldsEmpty(transaction); }

Provide Manual Amount Entry as Fallback in MoneyRequestPreview:

In the case of issues with the amount data, allow users to manually enter or correct the amount directly within the MoneyRequestPreview component. This could be implemented by introducing an input field

if (hasMissingSmartscanFields(transaction)) { return ( <InputField label={translate('iou.enterAmountManually')} defaultValue={displayAmount} onChangeText={(value) => updateTransactionAmount(transactionID, value)} /> ); }

JordanLevy19 avatar Feb 08 '24 17:02 JordanLevy19

Still looking for proposals here.

akinwale avatar Feb 12 '24 10:02 akinwale

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Feb 13 '24 16:02 melvin-bot[bot]

All good Melvin, waiting on proposals or urgency to move forward.

strepanier03 avatar Feb 14 '24 18:02 strepanier03

@akinwale @strepanier03 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Feb 20 '24 15:02 melvin-bot[bot]

@akinwale, @strepanier03 Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Feb 20 '24 15:02 melvin-bot[bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Feb 20 '24 16:02 melvin-bot[bot]

Proposals needed.

strepanier03 avatar Feb 20 '24 18:02 strepanier03

Waiting for proposals.

strepanier03 avatar Feb 23 '24 17:02 strepanier03

Waiting for proposals.

strepanier03 avatar Feb 26 '24 17:02 strepanier03

@akinwale @strepanier03 this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

melvin-bot[bot] avatar Feb 27 '24 15:02 melvin-bot[bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Feb 27 '24 16:02 melvin-bot[bot]

Tied to a VIP and waiting for proposals.

strepanier03 avatar Mar 01 '24 04:03 strepanier03

@akinwale - Somehow I missed this proposal, did you review it by any chance?

strepanier03 avatar Mar 01 '24 04:03 strepanier03

@strepanier03 Yes. The proposal does not solve the issue. Still looking for proposals.

akinwale avatar Mar 02 '24 13:03 akinwale

Thank you for making sure @akinwale, I appreciate it 🙌

strepanier03 avatar Mar 04 '24 23:03 strepanier03

Issue not reproducible during KI retests. (First week)

mvtglobally avatar Mar 05 '24 04:03 mvtglobally

@akinwale @strepanier03 this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

  • Decide whether any proposals currently meet our guidelines and can be approved as-is today
  • If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

melvin-bot[bot] avatar Mar 05 '24 15:03 melvin-bot[bot]

Current assignee @akinwale is eligible for the Internal assigner, not assigning anyone new.

melvin-bot[bot] avatar Mar 05 '24 15:03 melvin-bot[bot]

@akinwale @strepanier03 this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

melvin-bot[bot] avatar Mar 05 '24 19:03 melvin-bot[bot]

Awaiting ownership for a solution.

strepanier03 avatar Mar 08 '24 01:03 strepanier03

@akinwale, @strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Mar 11 '24 19:03 melvin-bot[bot]

Discussing whether or not to ask an expert agency to take on.

strepanier03 avatar Mar 12 '24 02:03 strepanier03

Current assignee @akinwale is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] avatar Mar 15 '24 16:03 melvin-bot[bot]

Since Melvin turned this internal, we can ask an agency if they want to work on it. Doing that now.

strepanier03 avatar Mar 15 '24 16:03 strepanier03

Posted here in Callstack. If no one picks it up, I'll post in SWM as well.

strepanier03 avatar Mar 15 '24 16:03 strepanier03

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Mar 16 '24 16:03 melvin-bot[bot]