App icon indicating copy to clipboard operation
App copied to clipboard

IOS - Tapping Download on “Share code” doesn’t always work

Open kbecciv opened this issue 1 year ago • 8 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.37-0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Issue found when executing PR https://github.com/Expensify/App/pull/34580

Action Performed:

  1. Launch the app and tap on the avatar on top right
  2. Tap on Share code > Download

Expected Result:

An image is downloaded with the QR code

Actual Result:

Most of the times nothing happens. If the Download icon is tapped several times rarely it does work

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [x] iOS: Native
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/401add3f-cda6-48fd-abd1-de19d54d0acc

View all open jobs on GitHub

kbecciv avatar Feb 06 '24 16:02 kbecciv

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

github-actions[bot] avatar Feb 06 '24 16:02 github-actions[bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] avatar Feb 06 '24 16:02 melvin-bot[bot]

We think that this bug might be related #vip-vsb CC @quinthar

kbecciv avatar Feb 06 '24 16:02 kbecciv

regression from :

https://github.com/Expensify/App/pull/34580

allgandalf avatar Feb 06 '24 16:02 allgandalf

Commented with the solution in offending PR

situchan avatar Feb 06 '24 16:02 situchan

If this becomes external, I would be willing to fix the issue :)

allgandalf avatar Feb 06 '24 16:02 allgandalf

@thienlnam do we need to CP this one to staging?

marcaaron avatar Feb 06 '24 21:02 marcaaron

Ah I didn't realize this was linked to a blocker - yeah I can get this CPed sorry

thienlnam avatar Feb 06 '24 22:02 thienlnam

This issue has not been updated in over 15 days. @thienlnam eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

melvin-bot[bot] avatar Mar 01 '24 15:03 melvin-bot[bot]

Closing - this was a regression that was fixed by the original author / reviewers

thienlnam avatar Mar 01 '24 23:03 thienlnam