[$500] Expense report shows up in LHN for "hidden" notification

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.37-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @puneetlath Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1707166993767269

Action Performed:

1. Set up the notification preference as "mute" for the expense report
2. Create an expense report as employee

Expected Result:

Expense reports shouldn't be showing up in the LHN because they have the hidden notification preference.

Actual Result:

every now and then, I'll see an expense report show up in my LHN as unread. Expense reports shouldn't be showing up in the LHN because they have the hidden notification preference. When I click into the report, mark the last message as unread, and leave, the report disappears from my LHN. This makes me think that the issue is that the report we send via pusher/push-notification doesn't have the notification preference, so the report is showing up in the LHN. Once I open the report, the OpenReport call returns the notification preference, which is why it then gets removed from the LHN

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ca8e68653740d492
• Upwork Job ID: 1754672476992069632
• Last Price Increase: 2024-02-06

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01ca8e68653740d492

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[melvin-bot[bot]]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lschurr]

Waiting for proposals.

[melvin-bot[bot]]

Current assignee @hoangzinh is eligible for the Internal assigner, not assigning anyone new.

[JmillsExpensify]

This needs to be fixed internally. @lschurr Can you float this one in wave7 so we can get a volunteer?

[lschurr]

Thanks for the bump @JmillsExpensify - I asked in Slack: https://expensify.slack.com/archives/C02NZ2HGJAZ/p1707495040686099

[lschurr]

Waiting on a volunteer in the Slack thread.

[lschurr]

Assigning over to @youssef-lr since you mentioned this has the same root cause as this one: https://github.com/Expensify/App/issues/35072

[youssef-lr]

I'm unable to reproduce this one so far, still on it.

[youssef-lr]

This should be fixed once this PR deploys.

[lschurr]

Looks like that PR was deployed today. Is this one fixed @youssef-lr?

[youssef-lr]

Correct @lschurr, it should be fixed now. Let's make this a weekly and keep an eye on it in case we missed something, but in my testing it's fixed.

[melvin-bot[bot]]

@hoangzinh @youssef-lr @lschurr this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[youssef-lr]

We haven't seen reports of this bug again, closing!