[$500] Send money -For send money, merchant shown as " Request "

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.36 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4281379 Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

1. Launch app
2. Tap fab----Send money
3. Enter an amount and tap next
4. Select a contact
5. Tap payelsewhere
6. Tap the send money request created to open details page
7. Note the merchant field

Expected Result:

For send money, merchant must not be shown as " Request "

Actual Result:

For send money, merchant shown as " Request "

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/2e12ba07-b1c8-4392-9a0b-1135e28a4325

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0133847fab45efc929
• Upwork Job ID: 1754204504573894656
• Last Price Increase: 2024-02-04

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~0133847fab45efc929

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[melvin-bot[bot]]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[DylanDylann]

It seems this Bug is from BE

[melvin-bot[bot]]

Current assignee @alitoshmatov is eligible for the Internal assigner, not assigning anyone new.

[muttmuure]

Seems related to: https://github.com/Expensify/App/pull/34216

[tgolen]

What is the expectation, that the merchant line is not shown at all, or that something other than "Request" is shown for the merchant? Also, what makes this a backend issue?

[deetergp]

That's a good question… If a user is just sending money to another user, does there need to be a merchant line at all? Wouldn't the merchant just be the sender? Maybe we should require the description field for Send Money to be filled out similar to Venmo.

[deetergp]

The merchant value of Request is coming from the back end.

[deetergp]

It's set in Transaction::createMoneyRequest in Auth.

[lisishyn]

There is already a nail for "Request" (CONST.TRANSACTION.DEFAULT_MERCHANT) in the MoneyRequestPreview. https://github.com/Expensify/App/blob/500dd0949123ae1cd7b84211c0093f3c832d6775/src/components/ReportActionItem/MoneyRequestPreview.tsx#L163

[melvin-bot[bot]]

📣 @lisishyn! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[lisishyn]

Contributor details Your Expensify account email: [email protected] Upwork Profile Link: https://www.upwork.com/freelancers/~015703306bbdfe0891

[melvin-bot[bot]]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[deetergp]

Started an internal conversation about this in #vip-split.

[deetergp]

Based on the conversation in the above thread, we are ultimately going to only ever show Amount and Description on Send money requests. Merchant will no longer be display once the work in this internal GH is complete. Closing this one out.