[$500] Assigned cards tile uses cardholderName- lastFourDigits instead of bankName - lastFourDigits

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.36-0 Reproducible in staging?: yes Reproducible in production?: yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @miljakljajic Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1706893917890069

Action Performed:

1. Assign a third party card feed to a test account in OldDot following these steps:
2. Navigate to Settings > Domains > Import Card to add the test card feed
3. Search ‘Discover’
4. Enter the login ‘expensifydemo’ and the password ‘#USD’
5. Assign the single available card to your test account
6. Navigate to NewDot and go to your Wallet > Assigned cards

Expected result:

You should see the bank logo of the assigned card labelled bankName - lastFourDigits

Actual result:

You will see the bank logo of the assigned card labelled

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cde3f6bc755e7553
• Upwork Job ID: 1753474213344817152
• Last Price Increase: 2024-02-02
• Automatic offers:
• Krishna2323 | Contributor | 28144685

Issue Owner

Current Issue Owner: @Krishna2323

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01cde3f6bc755e7553

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot[bot]]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

ssigned cards tile uses cardholderName- lastFourDigits instead of bankName - lastFourDigits

What is the root cause of that problem?

We are using card.cardName as title inside PaymentMethodList. https://github.com/Expensify/App/blob/3ab4e6e12d9ff38e69493321f0d31f032481b373/src/pages/settings/Wallet/PaymentMethodList.js#L232

What changes do you think we should make in order to solve the problem?

We need to use card.bank for the correct value. Also if we need last four digit we can use card.lastFourPAN use both.

                const cartTitle = card.lastFourPAN ? `${card.bank} - ${card.lastFourPAN}` : card.bank;
                return {
                    key: card.cardID,
                    title: isExpensifyCard ? expensifyCardDescription : cartTitle,

Result

[rushatgabhane]

🎀👀🎀

seems like a straightforward fix. let's go with https://github.com/Expensify/App/issues/35685#issuecomment-1925063317

[melvin-bot[bot]]

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[marcochavezf]

Assigning @Krishna2323 🚀 , thanks for the review @rushatgabhane

[melvin-bot[bot]]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[Krishna2323]

@rushatgabhane, PR is ready for a review, I just wanted to confirm one thing, last four digits refers to lastFourPAN, am I right? The object below refers to the discover.com bank info. Here we don't get lastFourPAN, maybe because this is a test account. I think we need to test it with a genuine bank card.

{
    "availableSpend": 0,
    "bank": "discover.com",
    "cardID": 18996283,
    "cardName": "AA Miles - 1979",
    "cardholderFirstName": "",
    "cardholderLastName": "",
    "domainName": "blogminutes.com",
    "fraud": "none",
    "isVirtual": false,
    "lastFourPAN": "",
    "maskedPan": "AA Miles - 1979",
    "state": 3
}

Also, I believe the domain name below the bank name should act like a link:

[Krishna2323]

@marcochavezf @miljakljajic can you pls check the above comment^. Thanks

[rushatgabhane]

@Krishna2323 let me add some card in my account to test

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[godofoutcasts94]

Please review this Proposal as it fixes the above issue.

[rushatgabhane]

discussion here https://expensify.slack.com/archives/C01GTK53T8Q/p1708558924151619

[rushatgabhane]

@bfitzexpensify could you please add payment summary, thanks 🙇 Payment due in 2 days

[rushatgabhane]

money request here - https://staging.new.expensify.com/r/3704912471626768

[bfitzexpensify]

Thanks for the heads up @rushatgabhane

Payment summary:

Contributor: @Krishna2323 to be paid $500 via Upwork ✅ C+: @rushatgabhane to be paid $500 via manual request

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @marcochavezf, @rushatgabhane, @bfitzexpensify, @Krishna2323 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[JmillsExpensify]

$500 approved for @rushatgabhane based on summary.