[Wave 8] [Ideal Nav] App crashes when navigating to Settings/Overview page of a non-existent workspace

[hayata-suenaga]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: Reproducible in staging?: Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

Action Performed:

1. On a browser, go to the Settings/Overview page of a workspace you don't have access to. You can use this example URL.

Expected Result:

Not-found page should appear

Actual Result:

The website crashes

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Screenshot attached above

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[trjExpensify]

What does "existent" workspace mean? A workspace you don't have access to or literally just a made up URL after /workspace?

[hayata-suenaga]

@trjExpensify good question! both workspaces you don't have an access to and made-up workspaces

[WojtekBoman]

Hi! I'm going to work on it :)

[trjExpensify]

Assigned you @WojtekBoman!

[trjExpensify]

@trjExpensify good question! both workspaces you don't have an access to and made-up workspaces

Okay, so I can't reproduce this one on staging when I modify the workspaceID to something that doesn't exist:

[trjExpensify]

Are there more conditions required than that? 🤔

[hayata-suenaga]

@trjExpensify thank you for checking this 🙇

I have confirmed that the issue doesn't occur when accessing a non-existent report. The crash only happens when you try to access an existing report to which you don't have access.

[trjExpensify]

Existing report? I thought we were talking about workspaces here? 🤔

[hayata-suenaga]

sorry I meant workspace 😓

[trjExpensify]

Got it, okay. Looks like we have a PR up for this.

[trjExpensify]

Assigning @ntdiary as the C+

[zanyrenney]

How come this isn't closed @JmillsExpensify ? looks like the PR merged a while ago?

[hayata-suenaga]

I think melvin messages weren't triggered automatically.

C+ preview payment for @ntdiary is needed here. After the payment is made, we can close this issue 👍

The pr was merged last week

[ntdiary]

I'm applying to switch to NewDot for payment, it might be better to process it after approval. 😄

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @JmillsExpensify, @ntdiary, @WojtekBoman, @hayata-suenaga eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[trjExpensify]

@JmillsExpensify this is ready for payment.

[ntdiary]

@JmillsExpensify this is ready for payment.

Eh, haha, I almost forgot about these issues. 😂 I wanted to switch to NewDot payment before, and still waiting to be added to the contributor policy.

[melvin-bot[bot]]

@JmillsExpensify, @ntdiary, @WojtekBoman, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[hayata-suenaga]

waiting for payment

[hayata-suenaga]

waiting for payment

[JmillsExpensify]

Payment summary: $500 for @ntdiary for pr review and testing.

[JmillsExpensify]

Contract sent via upwork.

[ntdiary]

Contract sent via upwork.

@JmillsExpensify thank you! Have accepted it. 😄

[JmillsExpensify]

Payment made