App [Wave 8] [Ideal Nav] Incorrect or missing brick road indicators

Action Performed:

GBR (Green brick road) and RBR (Red brick road) are not working with the introduction of Ideal Navigation (the new navigation structure). This is a widespread error. Please check major GBR and RBR flows. They're most likely broken.

Some example of GBR and RBR not working:

Some GBR and RBR are incorrectly displayed on on Workspace Switcher when there is no report with GBR and RGR in the workspace. https://github.com/Expensify/App/pull/33280#issuecomment-1911253960
RBR is incorrectly displayed on Profile Avatar https://github.com/Expensify/App/pull/33280#issuecomment-1880199054

Expected Result:

GBR and RBR should work.

Actual Result:

GBR and RBR are not working correctly.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

The links to videos are in the Action Performed section above.

View all open jobs on GitHub

Feb 01 '24 23:02 hayata-suenaga

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Feb 01 '24 23:02 melvin-bot[bot]

👋 Seems like there might be an issue with rows appearing unread as well: https://expensify.slack.com/archives/C036QM0SLJK/p1706888366992169

Feb 02 '24 17:02 trjExpensify

@hayata-suenaga - is this one ready to assign external or should it remain internal?

Feb 02 '24 22:02 alexpensify

I think there is someone from SWM already working on this. Let me check.

Feb 02 '24 23:02 hayata-suenaga

Does this issue still occur? I've added many fixes to displaying RBR/GBR since reporting this issue

Feb 05 '24 07:02 WojtekBoman

On the staging after the feature branch (the big PR) was merged, several issues were reported about RBR/GBR.

@WojtekBoman did you merge any PR after the feature branch was merged?

Feb 05 '24 17:02 hayata-suenaga

I haven't merged any PRs since the feature branch was merged, but this issue https://github.com/Expensify/App/pull/33280#issuecomment-1880199054 should no longer appear :) I had fixed it, before the ideal nav was merged to the main. Additionally this PR contains the fix for displaying RBR/GBR.

Feb 06 '24 11:02 WojtekBoman

thank you for letting me know about the work you did 🙇 I apologize I wasn't aware of the previous fixes you worked on.

I had a chance to try reproducing the the issue. When there is an money request that needs fix, I didn't see the RBR on the workspace list item nor on the chat list item.