App
App copied to clipboard
Expensify
[Wave 8] [Ideal Nav] Navigation among different Workspace Settings pages is broken
Action Performed:
- Test this on a browser
- Go to Workspace Settings page (make sure that you’re on a workspace in which you’re an admin so that you have enough settings items to navigate through).
- Click through different setting items (watch the video)
- Shrink the screen
- Press the browser back button several times.
Expected Result:
The back button should take you straight back to the Settings page where the settings items are listed.
Actual Result:
Clicking through the back button takes you to different settings item page previously visited.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [ ] Android: Native
- [ ] Android: mWeb Chrome
- [ ] iOS: Native
- [ ] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
https://github.com/Expensify/App/pull/33280#issuecomment-1880188621
Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
@hayata-suenaga I didn't see any response on the other issue. Did you find out if they are related? And if they are, should we add a HOLD on this issue, or just close it out?
I didn't see any response on the other issue. Did you find out if they are related?
asking directly on Slack
And if they are, should we add a HOLD on this issue, or just close it out?
is the issues turn out to be related, we can close this issue in favor of this one.
Let me get back to you once I get a response 👍
Hey @hayata-suenaga, this one won't be solved by the goback workaround and may be tricky. I'll take a look at it when I have some free time. But maybe in the meantime, we could change it to weekly?
@sakluger @hayata-suenaga this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
@sakluger @hayata-suenaga this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!
Adam is OOO and they will work on this once they're back. This issue will also take time to fix.
Since it sounds like this will take a bit more time, I'm going to move this to weekly to avoid it going overdue.
@sakluger @hayata-suenaga this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!
Job added to Upwork: https://www.upwork.com/jobs/~0112c8e18133890b6e
Triggered auto assignment to Contributor Plus for review of internal employee PR - @c3024 (Internal)
@adamgrzybowski is going to work on this. because the solution is a little bit tricky, it might take some time. Melvin, please chill 🙇
@WojtekBoman Let me know if https://github.com/Expensify/App/issues/37359 is related
What are the next steps here? Is this on hold for the issue to refactor goBack logic?
Thank you Tom for checking on the status
I re-tested this, and I was not able to repro. @WojtekBoman, could you double confirm this? If you can't also repro, we can close this issue.
Unfortunately, it seems to be still present:
https://github.com/Expensify/App/assets/47774969/525ec05f-c88d-448b-8309-bf9e611bfba8
We've spent some time on investigation this issue with @adamgrzybowski and it's a bit complex to fix, because we can't directly modify browser history. Fixing this issue might require many changes in the logic that works fine, and this case shouldn't be common for users. We had to switch to work on the new search tab and I'm wondering what should we do with this task, because as I mentioned it's not a common issue and handling that might require some interference with browser history and I'm not sure if we want to make such deep changes to deal with that.
Is this specifically a bug on Web when you're shrinking your screen link that or was that just to replicate a native mobile experience?
@trjExpensify I believe this is specific to the web.
I believe that we don't have to spend time on fixing this. The fix might also further complicates the navigation logic that is already hard to understand. I'd say let's close this issue, but I'll wait for @trjExpensify's response.