App
App copied to clipboard
Expensify
[HOLD App#35603] [Wave8] [Account Settings] Update Preferences page
Coming from tracking issue for this initiative.
Using the Figma final mocks, please update the Account Settings Preferences page in the new ideal navigation layout to look like this:
For help with anything unclear, please, post in wave8 room.
Please tag design team for a review on the PR before merging.
cc @trjExpensify @dannymcclain
Triggered auto assignment to @garrettmknight (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hey, I'm Kuba from Software Mansion and I will work on this issue.
The draft of the PR is already prepared, but we are waiting for the #35603 to be merged.
I'll take the BZ on the main from @garrettmknight, given I'm closer to this.
👋 Can we get marketing copy for the subheader intro on these pages where there's filler right now, please? Thanks!
Preferences
TRJ suggestion for consideration: Customise your Expensify experience.
Security
TRJ suggestion for consideration: Enable 2FA to keep your account extra safe, or close your account if you no longer need it.
Share code
TRJ's suggestion: Invite people to Expensify by sharing a personalised QR code or link.
Triggered auto assignment to @NickTooker (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.
Customize your Expensify account. Is there a reason your suggestions was to use the word "experience"? I'm not sure we use that widely elsewhere so I think account may be better.
Enable two-factor authentication to keep your account safe, or close your account if you no longer need it. Let's keep 'two factor authentication' consistent vs 2FA - let's remove extra, it doesn't add to the sentence here IMO.
Refer members to Expensify by sharing your personal QR code or referral link. I'm using Refer, members, and referral here to be consistent with language we've used elsewhere - please let me know if you disagree.
@trjExpensify Let me know your thoughts.
Customize your Expensify account. Is there a reason your suggestions was to use the word "experience"? I'm not sure we use that widely elsewhere so I think account may be better.
No strong reason. I just thought "experience" sounded nicer as they kinda' fell into that for me. I.e your theme, LHN sorting logic, language. Though I guess there's a marketing preference toggle in there, so maybe it doesn't quite wholly fit. Not passionate!
Enable two-factor authentication to keep your account safe, or close your account if you no longer need it. Let's keep 'two factor authentication' consistent vs 2FA - let's remove extra, it doesn't add to the sentence here IMO.
Cool, I think this one is now pretty long -- especially for mobile. Perhaps we just cut the close account part? I.e
Enable two-factor authentication to keep your account safe.
Refer members to Expensify by sharing your personal QR code or referral link. I'm using Refer, members, and referral here to be consistent with language we've used elsewhere - please let me know if you disagree.
Nice edit. Maybe we avoid the "refer/referral" repetition though and switch the first word to "invite"? I.e
Invite members to Expensify by sharing your personal QR code or referral link.
>Enable two-factor authentication to keep your account safe. Perfect. Close account button speaks for itself.
>Invite members to Expensify by sharing your personal QR code or referral link. Good catch on refer/referral - this looks great to me.
Love this! Should I update the mocks?! :excited:
Also can we get one more for Test preferences? Obviously this one is not as important, but still. Maybe something simple like Configure your account's test preferences?
Yes, I'm not sure what else we would say here. I am fine with:
>Configure your account's test preferences.
Should I update the mocks?! :excited:
Do it!
Also can we get one more for Test preferences? Obviously this one is not as important, but still. Maybe something simple like Configure your account's test preferences?
Ah shit yeah, forgot about that one. These are only displayed on staging, so maybe the below? 🤔
Test preferences Settings to help debug and test the app on staging.
These are only displayed on staging
Good catch! Agreed with your copy suggestion then.
Cool, @kosmydel.. the mock in the OP of this issue has been updated for Preferences. 👍
Here are all the Spanish translations for those:
Preferencias de la aplicación Personaliza tu cuenta de Expensify.
Preferencias para tests Ajustes para ayudar a depurar y probar la aplicación en “staging”.
Opciones de seguridad Activa la autenticación de dos factores para mantener tu cuenta segura.
Tu código Invita a miembros a Expensify compartiendo tu código QR personal o enlace de invitación.
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
Okay, so payment time I think here. @s77rt you were the PR reviewer on this, right? Are these regression pings above bogus?
@trjExpensify Yes I reviewed the PR. There were 2 bugs https://github.com/Expensify/App/issues/36444 and https://github.com/Expensify/App/pull/35672#discussion_r1488674313.
Can you assign me here?
Alright, I'm not going to reduce for those minor bugs given we rolled in a couple of other pages to that PR. So I'll send you an offer for $500 for the C+ review. Does that work for you?