App icon indicating copy to clipboard operation
App copied to clipboard

[HOLD App#35603] [Wave8] [Account Settings] Update Share Code page

Open mountiny opened this issue 1 year ago • 3 comments

Coming from tracking issue for this initiative.

Using the Figma final mocks, please update the Account Settings Share Code page in the new ideal navigation layout to look like this:

image

For help with anything unclear, please, post in wave8 room.

Please tag design team for a review on the PR before merging.

cc @trjExpensify @dannymcclain

mountiny avatar Feb 01 '24 23:02 mountiny

Triggered auto assignment to @garrettmknight (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

melvin-bot[bot] avatar Feb 01 '24 23:02 melvin-bot[bot]

Will be handled by SWM

mountiny avatar Feb 02 '24 18:02 mountiny

Updated the mock in the OP of this issue to replace the placeholder subheader copy!

trjExpensify avatar Feb 05 '24 23:02 trjExpensify

Note: Won't apply rounded QRCode cause library does not support it.

filip-solecki avatar Feb 08 '24 12:02 filip-solecki

Assigning @situchan as they are reviewing the associated PR.

blimpich avatar Feb 08 '24 19:02 blimpich

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] avatar Feb 13 '24 18:02 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.40-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/36120

If no regressions arise, payment will be issued on 2024-02-20. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @situchan requires payment (Needs manual offer from BZ)

melvin-bot[bot] avatar Feb 13 '24 18:02 melvin-bot[bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [ ] [@situchan] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [ ] [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

melvin-bot[bot] avatar Feb 13 '24 18:02 melvin-bot[bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] avatar Feb 14 '24 19:02 melvin-bot[bot]

@sonialiap reassigning for payment since I'll be OOO when the date comes. Thanks!

garrettmknight avatar Feb 14 '24 19:02 garrettmknight

$500 to @situchan and no regression tests required

mountiny avatar Feb 14 '24 20:02 mountiny

@situchan $500 - offer sent

Job https://www.upwork.com/ab/applicants/1759618198049271808/job-details

sonialiap avatar Feb 19 '24 16:02 sonialiap

Paid ✔️

sonialiap avatar Feb 20 '24 09:02 sonialiap