[$500] Home - When banner pop up remains opened, expensify logo and profile icon cannot be seen

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.35 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4263441 Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

1. Login using new account in both mweb and app
2. Note, a banner pop up is displayed

Expected Result:

In mweb, when banner pop up remains opened, expensify logo and profile icon user must be able to see like in Android app

Actual Result:

In mweb, when banner pop up remains opened, expensify logo and profile icon cannot be seen but in Android app, it can be seen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/3fc7f3ea-bf95-495e-a7e7-ff894f04daae

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01341c171ea9087168
• Upwork Job ID: 1753150891535253504
• Last Price Increase: 2024-02-01

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01341c171ea9087168

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot[bot]]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Home - When banner pop up remains opened, expensify logo and profile icon cannot be seen

What is the root cause of that problem?

The problem is related to since more content fits on a mobile device, we have free space In turn, the mobile-web device requires more space (Since we have a search bar in browsers )

What changes do you think we should make in order to solve the problem?

To fix this issue we can decrease the maximum height Whatever content we always had free space at the top

For example

<View style={{maxHeight: windowHeight - 20}}>

And padding will depend on the decision of the designers

And if we want we can make specific it for specific platforms(optional)

https://github.com/Expensify/App/blob/c8679c727db9755404599fa61943d3a36e1a1f68/src/components/PurposeForUsingExpensifyModal.tsx#L146

What alternative solutions did you explore? (Optional)

As alternative we can add flexGrow: 1 so that the modal window takes up all the available space

https://github.com/Expensify/App/blob/c8679c727db9755404599fa61943d3a36e1a1f68/src/components/PurposeForUsingExpensifyModal.tsx#L146

Thinking out loud (But in this case, top border-radius looks pointless)

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Home - When banner pop up remains opened, expensify logo and profile icon cannot be seen

What is the root cause of that problem?

On this line the maxHeight of the modal container is set to windowHeight

What changes do you think we should make in order to solve the problem?

Change maxHeight to windowHeight - variables.contentHeaderHeight

What alternative solutions did you explore? (Optional)

[eVoloshchak]

In mweb, when banner pop up remains opened, expensify logo and profile icon cannot be seen but in Android app, it can be seen

@strepanier03, I'm not sure if the expected result is correct here Shouldn't the banner cover all of the screen instead? (i.e. it should look like it currently looks on mWeb)

[strepanier03]

Hmmm, good question. I'll have to repro and then raise internally for a chat about expected behavior.

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@eVoloshchak, @strepanier03 Huh... This is 4 days overdue. Who can take care of this?

[strepanier03]

Raised here, waiting for discussion.

[strepanier03]

Per Shawn.

I don't think this is a bug, I think it depends on screen height. I've mentioned this to @bstites before but I think in hindsight we probably should have made this a full screen experience. But we have some upcoming onboarding changes on the way so it's probably (not) worth touching this since things are changing anyways.

IN light of the changes coming and the suggestion we don't touch this, I'm going to clos.