App icon indicating copy to clipboard operation
App copied to clipboard

Adding a comment in domain char #expensifail.com crashes

Open m-natarajan opened this issue 1 year ago • 5 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.35-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @aldo-expensify Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1706747593037209

Action Performed:

  1. Sign into https://staging.new.expensify.com/r/75431276 on a browser with an expensifail account
  2. Click the search bar in the upper left corner and search for "#expensifail.com" room
  3. Try to add a comment
  4. Verify you get an error (Auth GetRestrictedAuthTokenByEmail returned an error)

Expected Result:

The comment should be added

Actual Result:

Error appears: Unexpected error while posting the comment, please try again laterAuth GetRestrictedAuthTokenByEmail returned an error

Logs: https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%2284e610de98092d8a-YVR%22)+AND+timestamp:[2024-01-31T23:26:57.858Z+TO+2024-02-01T01:26:57.858Z]&index=logs_expensify-026557

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [X] Android: Native
  • [X] Android: mWeb Chrome
  • [X] iOS: Native
  • [X] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [X] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence image (3)

image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018aa801eb047294a0
  • Upwork Job ID: 1753560316765069312
  • Last Price Increase: 2024-02-02

m-natarajan avatar Feb 01 '24 04:02 m-natarajan

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] avatar Feb 01 '24 04:02 melvin-bot[bot]

I can reproduce this - updated the OP with the details.

I think this needs to be internal? adding that label for a buddy check.

Christinadobrzyn avatar Feb 02 '24 23:02 Christinadobrzyn

Job added to Upwork: https://www.upwork.com/jobs/~018aa801eb047294a0

melvin-bot[bot] avatar Feb 02 '24 23:02 melvin-bot[bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @getusha (Internal)

melvin-bot[bot] avatar Feb 02 '24 23:02 melvin-bot[bot]

I think this can be part of vip-vsb since it relates to chat - I think this need to be internal based on the error

Christinadobrzyn avatar Feb 06 '24 00:02 Christinadobrzyn

Asking in the vsb Slack channel how we want to handle this one - https://expensify.slack.com/archives/C066HJM2CAZ/p1707247660309079

Christinadobrzyn avatar Feb 06 '24 19:02 Christinadobrzyn

Since this is internal - we're waiting for someone to pick this up

Christinadobrzyn avatar Feb 08 '24 23:02 Christinadobrzyn

@Christinadobrzyn, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Feb 12 '24 15:02 melvin-bot[bot]

Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.

melvin-bot[bot] avatar Feb 12 '24 18:02 melvin-bot[bot]

Going to add a few more labels to this job to try and get someone internally to pick it up. I think this is an internal job and I believe it is ready for someone to grab!

Christinadobrzyn avatar Feb 12 '24 18:02 Christinadobrzyn

still waiting on this to get picked up

Christinadobrzyn avatar Feb 14 '24 01:02 Christinadobrzyn

@Christinadobrzyn @getusha this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Feb 15 '24 15:02 melvin-bot[bot]

Keeping this internal for eng to pick up when they have the bandwidth!

Christinadobrzyn avatar Feb 15 '24 17:02 Christinadobrzyn

@Christinadobrzyn, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Feb 19 '24 15:02 melvin-bot[bot]

same status - https://github.com/Expensify/App/issues/35538#issuecomment-1946756660

Christinadobrzyn avatar Feb 20 '24 15:02 Christinadobrzyn

same status - https://github.com/Expensify/App/issues/35538#issuecomment-1946756660

Christinadobrzyn avatar Feb 21 '24 21:02 Christinadobrzyn

@Christinadobrzyn @getusha this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

melvin-bot[bot] avatar Feb 22 '24 15:02 melvin-bot[bot]

Internal label so we're waiting for someone to pick this up. However gonna test again today to see if it's still happening.

Christinadobrzyn avatar Feb 22 '24 15:02 Christinadobrzyn

This issue still exists, it's such a singular issue though... and it seems like the "Auth GetRestrictedAuthTokenByEmail returned an error" error is happening in Concierge and OldDot.

Logs: https://www.expensify.com/_devportal/tools/logSearch/#sort=asc&size=10000&query=blob%3A%22Auth%20GetRestrictedAuthTokenByEmail%20returned%20an%20error%22%20AND%20email%3A%22c.dobrzyn%2B87%40expensifail.com%22%20AND%20timestamp%3A%5B2024-02-16T00%3A00%20TO%202024-02-24T23%3A59%5D

image

We'll keep this open to see if someone would be able to grab it next week.

Christinadobrzyn avatar Feb 23 '24 23:02 Christinadobrzyn

waiting for someone internal to get this

Christinadobrzyn avatar Feb 26 '24 21:02 Christinadobrzyn

Issue not reproducible during KI retests. (First week)

mvtglobally avatar Feb 27 '24 15:02 mvtglobally

oh exciting! testing again... hum... still getting the error when trying to send a message to the #expensifail.com room.

image

Christinadobrzyn avatar Feb 28 '24 01:02 Christinadobrzyn

asking QA to retest - https://expensify.slack.com/archives/C9YU7BX5M/p1709250511129789

Christinadobrzyn avatar Feb 28 '24 21:02 Christinadobrzyn

@Christinadobrzyn @getusha this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

melvin-bot[bot] avatar Feb 29 '24 15:02 melvin-bot[bot]

There doesn't seem to be a way to add QA to our expensifail.com room in NewDot to test this. Asking @mallenexpensify if he can test for us to see if this is still happening - https://expensify.slack.com/archives/C01SKUP7QR0/p1709329998662989?thread_ts=1709307595.245699&cid=C01SKUP7QR0

Christinadobrzyn avatar Mar 01 '24 21:03 Christinadobrzyn

I think this is still happening and I think it needs to be internal since it's affecting the expensifail.com accounts.

Christinadobrzyn avatar Mar 01 '24 21:03 Christinadobrzyn

Was able to reproduce. image

Logs - logs-2024-03-01 23_38_25.029.txt

I logged out/in, and cleared cookies + local storage and the issue persists. Even though it shows an error when sending, when I signed back in, I saw messages that went through.

image

mallenexpensify avatar Mar 01 '24 23:03 mallenexpensify

Oh interesting- since it's only affecting this one room, I'm not sure if this needs to be fixed @getusha what's your take?

Christinadobrzyn avatar Mar 04 '24 21:03 Christinadobrzyn

I think this should still be evaluated by an internal engineer so going to keep this open for pick up

Christinadobrzyn avatar Mar 07 '24 05:03 Christinadobrzyn

this is ready for pick up by an internal engineer

Christinadobrzyn avatar Mar 12 '24 07:03 Christinadobrzyn