Backwards Compatibility: Tag disabled in OldDot is displayed in tags list during IOU creation in NewDot

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.34.0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

Precondition: User is Employee of Collect workspace and

1. Navigate to workspace chat as employee
2. Click +> Request money> Manual
3. As Admin navigate to Old dot and disable Tag 1
4. As employee on click on Tag section and check the list

Expected Result:

Tag 1 should not be present in tags list

Actual Result:

Tag 1 should is present in tags list

Workaround:

Unknow

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/c236ec4e-2de3-42ba-9de9-c522b3fc78c8

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kbecciv]

We think that this bug might be related to #wave6-collect-submitters CC @greg-schroeder

[greg-schroeder]

This might be more Wave 8 as it's related to an admin action and workspace configuration... thoughts @zanyrenney?

[strepanier03]

@zanyrenney - This is reproducible, do you agree including in Wave 8? Feel free to update the project and urgency label if you agree or let me know what you think otherwise.

[melvin-bot[bot]]

@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[strepanier03]

@zanyrenney - I'm going to add to Wave 8, let me know if you want it removed to it fits elsewhere.

[melvin-bot[bot]]

@strepanier03 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[strepanier03]

I'm going to assume this is an internal issue but could easily be wrong. Let me know if I should change this!

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01dedbcd7acaf45c5a

[melvin-bot[bot]]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @jjcoffee (Internal)

[jjcoffee]

Can't repro on v1.4.42-1 @kbecciv can you retest?

[kbecciv]

@jjcoffee Checking

[kbecciv]

Issue is still reproducible

https://github.com/Expensify/App/assets/93399543/e39e8c48-08fb-4ab6-b6e7-8d8c7b01b00b

[melvin-bot[bot]]

@strepanier03, @jjcoffee Whoops! This issue is 2 days overdue. Let's get this updated quick!

[strepanier03]

All good Melvin.

[jjcoffee]

@kbecciv Thanks for retesting! I think what's happening here is that you're opening the tag menu "too fast", so the pusher event hasn't come through yet and it doesn't update the list to remove the disabled tag whilst the tag selection modal is open.

If you navigate back and reopen the tag should be removed from the list (at least that's what I see). So I guess there is a minor bug there that the item isn't removed from the list whilst it's open, the question is is that worth fixing? cc @strepanier03

[melvin-bot[bot]]

@strepanier03 @jjcoffee this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[strepanier03]

Thank you @jjcoffee - I'm raising it internally so we can chat about it a bit and decide how to move forward.

[strepanier03]

Raised here, will follow up.

[strepanier03]

Okay, we're putting this one on hold for https://github.com/Expensify/App/issues/35909 and we'll see if that resolves this one when it closes.

[strepanier03]

Hold GH is still open, still holding.

[strepanier03]

HOLD GH is now closed, switching to Daily and I'll work on this tomorrow.

[strepanier03]

Asked for a retest here.

[kavimuru]

@strepanier03 Issue is reproduced in real time. If the page is refreshed on employee side then issue is not reproduced.

https://github.com/Expensify/App/assets/43996225/81ddd18a-4dc7-4930-99d4-f43ddd2957c7

https://github.com/Expensify/App/assets/43996225/f529ca41-36ef-4b40-b855-9497173f0c3b

[strepanier03]

Thank you Kavi, this is assigned to a project so we'll wait for it to be picked up.

[strepanier03]

Labeled ToDo, so likely to be a bit before it's picked up.

[melvin-bot[bot]]

@strepanier03, @jjcoffee 12 days overdue now... This issue's end is nigh!

[melvin-bot[bot]]

This issue has not been updated in over 14 days. @strepanier03, @jjcoffee eroding to Weekly issue.

[strepanier03]

Not set to a priority at this time but held for the future.

[strepanier03]

Waiting for prioritization.