Remove MoneyRequestSelectorPage.js and copy any changes since Nov 27 into IOURequestStartPage.js.

[Krishna2323]

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/34613 PROPOSAL: https://github.com/Expensify/App/issues/34613#issuecomment-1894553516

Tests

1. Press on the + button

2. Choose Request money

3. For each tab complete a request and verify everything works correctly

4. Press on the + button

5. Choose Send money

6. Complete the flow & verify everything works correctly

7. Go to any 1:1 report

8. Click on + button in the composer

9. Choose Request money

10. For each tab complete a request and verify everything works correctly

11. Go to any 1:1 report

12. Click on + button in the composer

13. Choose Send money

14. Complete the flow & verify everything works correctly

• [x] Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

• [x] Verify that no errors appear in the JS console

PR Author Checklist

• [x] I linked the correct issue in the ### Fixed Issues section above
• [x] I wrote clear testing steps that cover the changes made in this PR
  • [x] I added steps for local testing in the Tests section
  • [x] I added steps for the expected offline behavior in the Offline steps section
  • [x] I added steps for Staging and/or Production testing in the QA steps section
  • [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• [ ] I included screenshots or videos for tests on all platforms
• [x] I ran the tests on all platforms & verified they passed on:
  • [ ] Android: Native
  • [x] Android: mWeb Chrome
  • [x] iOS: Native
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop
• [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• [x] I followed proper code patterns (see Reviewing the code)
  • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • [x] I verified that comments were added to code that is not self explanatory
  • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [x] I followed the guidelines as stated in the Review Guidelines
• [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• [x] I verified that if a function's arguments changed that all usages have also been updated correctly
• [x] If any new file was added I verified that:
  • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [x] If a new CSS style is added I verified that:
  • [x] A similar style doesn't already exist
  • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [x] If the PR modifies the form input styles:
  • [x] I verified that all the inputs inside a form are aligned with each other.
  • [x] I added Design label so the design team can review the changes.
• [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/85894871/9b3e917d-2754-4616-b103-e05e8d77c445

Android: mWeb Chrome

https://github.com/Expensify/App/assets/85894871/d09040fd-6608-490d-a540-14d1aae3c169

iOS: Native

https://github.com/Expensify/App/assets/85894871/2ad225da-2326-468a-944f-e49718580e02

iOS: mWeb Safari

https://github.com/Expensify/App/assets/85894871/a325cfa7-eb73-41d2-bf5b-c7480c2ba3f4

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/85894871/e9affc97-8a54-4928-b243-2151b3e8e589

MacOS: Desktop

https://github.com/Expensify/App/assets/85894871/be68fc8a-04c5-4d18-9a3d-f1025d479f20

[melvin-bot[bot]]

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[Krishna2323]

I'm still working on this to make sure it doesn't cause any regression...

[DylanDylann]

@Krishna2323 Please take a look at send money flow

[Krishna2323]

@DylanDylann, what do you mean by it? I know there is issue in the whole flow and I'm already trying to handle it, you can check the changes.

[Krishna2323]

@hoangzinh, can you pls review this once.

[hoangzinh]

I see that the PR is not ready yet, the checklist is not completed and recordings as well.

[Krishna2323]

@hoangzinh, screenshots added and checklist is also complete, you can review now.

[hoangzinh]

Please merge latest main to solve TS failed

[hoangzinh]

Sorry for delay @Krishna2323, I will continue to review today

[hoangzinh]

Just a few feedbacks, otherwise looks great.

[hoangzinh]

@Krishna2323 let me know when the PR is ready to review again. Thanks

[DylanDylann]

@Krishna2323 Please help to speed up this PR. Because this PR is blocking many other issues

[Krishna2323]

@DylanDylann, I will try to finish today, sorry for the delay but I'm not delaying intentionally. I'm trying to avoid any regressions.

[Krishna2323]

Looks like almost everything is done here, just need one confirmation from @hoangzinh and then will do final testing.

[Krishna2323]

@hoangzinh, can you pls do the final testing, I think everything is done now.

[abdulrahuman5196]

Hi, Could you kindly update this PR? We have other issues pending on this?

@Krishna2323 / @hoangzinh

[Krishna2323]

waiting for @DylanDylann's reply on this.

[hoangzinh]

@Krishna2323 Could you help to fix the typescript and conflict? I will do review checklist right after that. Thanks

[Krishna2323]

@hoangzinh, Conflicts are resolved but typecheck fails are coming from main so we can't do something there.

[hoangzinh]

Could you check out to latest main and run npm run typecheck? It's weird that there is no TS error in latest main.

[Krishna2323]

@hoangzinh, currently on main there is one type check failing but on our PR there are 3. What we can do here?🙇🏻

[Krishna2323]

Asked for help on Slack.

[Krishna2323]

@hoangzinh, TypeScript checks passed, conflicts resolved😭, can you pls review🙏🏻

[hoangzinh]

@Krishna2323 could you help to re-test again too? Thanks

[srikarparsi]

Hey! How's this PR going? Is there an ETA for when it will be ready for review?

[parasharrajat]

There is an issue held on this PR. is there an ETA on this?

[hoangzinh]

@Krishna2323 could you give ETA when it will be ready for the next review? Thanks

[Krishna2323]

@hoangzinh its ready, need to test one last time.

[Krishna2323]

Tested the flow again, seems to work fine.

cc: @hoangzinh

[hoangzinh]

Bug 1: Unable to select another currency

https://github.com/Expensify/App/assets/9639873/46ffa8b6-6eee-44b2-9b54-8087c4527ae0