App icon indicating copy to clipboard operation
App copied to clipboard

[$500] [CRITICAL] Backwards Compatibility - "Unavailable workspace" is displayed in the IOU details header

Open kavimuru opened this issue 1 year ago • 12 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: Reproducible in staging?: Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

Action Performed:

  1. Open https://staging.new.expensify.com/
  2. Log in with a new account
  3. Add this account as an employee in Group Policy in OldDot
  4. Under the employee account in NewDot, navigate to the Group Policy chat room
  5. Send a manual IOU to the conversation
  6. Navigate to IOU Report Conversation

Expected Result:

The WS name must be defined correctly in all menus and reports

Actual Result:

When creating an IOU in a WS room by a newly invited employee in Group Policy, it displays "Unavailable workspace" in Report Conversation

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [x] Android: Native
  • [x] Android: mWeb Chrome
  • [x] iOS: Native
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/43996225/4af373be-8932-42e9-9d66-819072c90ff5

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0146620fb0e6706fd3
  • Upwork Job ID: 1752289695969165312
  • Last Price Increase: 2024-02-07

kavimuru avatar Jan 30 '24 11:01 kavimuru

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] avatar Jan 30 '24 11:01 melvin-bot[bot]

Job added to Upwork: https://www.upwork.com/jobs/~0146620fb0e6706fd3

melvin-bot[bot] avatar Jan 30 '24 11:01 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

melvin-bot[bot] avatar Jan 30 '24 11:01 melvin-bot[bot]

Waiting for proposal

DylanDylann avatar Feb 02 '24 05:02 DylanDylann

@miljakljajic, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Feb 05 '24 15:02 melvin-bot[bot]

Still waiting for proposal

DylanDylann avatar Feb 05 '24 15:02 DylanDylann

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

rezkiy37 avatar Feb 07 '24 10:02 rezkiy37

So, I've investigated the problem. Looks like the app does not have all details about a newly added workspace for some initial period. The app does not have such important properties like: name and isPolicyExpenseChatEnabled. I think that must be investigated from the backend side to handle this data gap and add/pass all important properties.

Screenshot 2024-02-07 at 16 10 56

https://github.com/Expensify/App/assets/57314631/ed4c7aa1-8717-4508-b996-ad5bb188d675

rezkiy37 avatar Feb 07 '24 15:02 rezkiy37

@DylanDylann, please take a look at a comment above.

rezkiy37 avatar Feb 07 '24 15:02 rezkiy37

I'll share this internally @rezkiy37 and get more eyes on your comments/thesis. Thank you for investigating! I think this relates to wave6 - I'll tag you in my comment

miljakljajic avatar Feb 07 '24 16:02 miljakljajic

Current assignee @DylanDylann is eligible for the Internal assigner, not assigning anyone new.

melvin-bot[bot] avatar Feb 07 '24 19:02 melvin-bot[bot]

Actually maybe this could go in Critical as it's a cross-compatibility bug in the end

greg-schroeder avatar Feb 07 '24 23:02 greg-schroeder

This got deployed to prod, I think we can close it.

rlinoz avatar Feb 14 '24 17:02 rlinoz