App
App copied to clipboard
Expensify
[HOLD for payment 2024-02-07] [HOLD for payment 2024-02-07] [$500] Personal details - First item in the list is not highlighted when searching for country
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v1.4.33-3 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:
Action Performed:
- Go to Settings > Profile > Personal details.
- Go to Address.
- Go to Country.
- Search for any country.
Expected Result:
The first item in the list is highlighted.
Actual Result:
The first item in the list is not highlighted.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [x] Android: Native
- [x] Android: mWeb Chrome
- [x] iOS: Native
- [x] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [x] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/43996225/d9bca3ec-0810-4f16-a652-9b85e0baaa30
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01fc6fb38951fd8aeb
- Upwork Job ID: 1752281579575689216
- Last Price Increase: 2024-01-30
Job added to Upwork: https://www.upwork.com/jobs/~01fc6fb38951fd8aeb
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Triggered auto assignment to @lakchote (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Personal details - First item in the list is not highlighted when searching for country
What is the root cause of that problem?
This the regression from issue - 34485.
What changes do you think we should make in order to solve the problem?
If we change it from !canSelectMultiple to canSelectMultiple it will solve the issue.
https://github.com/Expensify/App/blob/aaa658fed7af4696e463cc80d93fd45054a4e889/src/components/SelectionList/BaseSelectionList.tsx#L357-L359
https://github.com/Expensify/App/assets/139276547/4d4812b4-7b4e-4dcc-bee2-359b4ec26d20
What alternative solutions did you explore? (Optional)
N/A
@AnshuAgarwal24 Won't that re-create the issue fixed in https://github.com/Expensify/App/pull/34485 ?
I think this one should probably be dealt with by the PR authors given it's in the regression period. @neonbhai @eVoloshchak
@AnshuAgarwal24 Won't that re-create the issue fixed in #34485 ?
I think this one should probably be dealt with by the PR authors given it's in the regression period. @neonbhai @eVoloshchak
That's my concern too. I've tagged the PR authors on Slack and I'll revert the changes in the meantime.
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
I think this one should probably be dealt with by the PR authors given it's in the regression period. @neonbhai @eVoloshchak
Agree
Reviewing label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.33-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
- https://github.com/Expensify/App/pull/35386
If no regressions arise, payment will be issued on 2024-02-07. :confetti_ball:
For reference, here are some details about the assignees on this issue:
- @Ollyws requires payment (Needs manual offer from BZ)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [ ] [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
- [ ] [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [ ] [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [ ] [@Ollyws] Determine if we should create a regression test for this bug.
- [ ] [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [ ] [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.34-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
- https://github.com/Expensify/App/pull/35386
If no regressions arise, payment will be issued on 2024-02-07. :confetti_ball:
For reference, here are some details about the assignees on this issue:
- @Ollyws requires payment (Needs manual offer from BZ)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [ ] [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
- [ ] [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [ ] [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [ ] [@Ollyws] Determine if we should create a regression test for this bug.
- [ ] [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [ ] [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Payment Summary
- ROLE: @Ollyws paid $(AMOUNT) via Upwork (LINK)
BugZero Checklist (@MitchExpensify)
- [ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
- [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1752281579575689216/hired)
- [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
- [ ] I have verified the payment summary above is correct