[$500] Manually entered fields replace by smart scan

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.32-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @neil-marcellini Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1706287604236959

Action Performed:

1. Request money
2. Scan a valid receipt
3. Request from a workspace
4. Open the new request and navigate down to the transaction report
5. Edit the amount manually and save
6. Wait for the smart scan details to fill Note: There may be a slight race condition here. It seems likely that the manually entered amount updated in the UI optimistically, but had not been processed by the server before the smart scan details were saved. We need to ensure that manually entered fields with optimistic values are not replaced.

Expected Result:

Smart scan fills in all fields that were not manually entered

Actual Result:

Smart scan fills in all fields, replacing the amount I manually entered## Expected Result: Describe what you think should've happened

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e3d084ff93c11990
• Upwork Job ID: 1752553739315617792
• Last Price Increase: 2024-01-31

[melvin-bot[bot]]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01e3d084ff93c11990

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[melvin-bot[bot]]

@cubuspl42, @kadiealexander Huh... This is 4 days overdue. Who can take care of this?

[kadiealexander]

Not overdue.

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

[rezkiy37]

I've investigated the bug. Looks like the backend does not overwrite manually entered fields. Actually, a behaviour seems like the backend stops to smart scan a receipt, once an user sends an update of a current report. So, I tested a case when the same receipt I allowed to smart scan fully, another case is to modify a field like amount, merchant and date. For the second case, if I modify a field during smart scanning, the backend returns a status "OPEN", not a "SCANNING" one. Can we confirm that the current behaviour is correct?

https://github.com/Expensify/App/assets/57314631/b776ebfd-a4f9-42c6-8f69-a72e786ff535

Auto scanned

Edited during scanning

[rezkiy37]

Still waiting on some feedback about a comment above.

[melvin-bot[bot]]

@cubuspl42 @kadiealexander this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot[bot]]

@cubuspl42, @kadiealexander Huh... This is 4 days overdue. Who can take care of this?

[kadiealexander]

@cubuspl42 bump!!

[cubuspl42]

🎀 👀 🎀

[melvin-bot[bot]]

Triggered auto assignment to @roryabraham, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[cubuspl42]

@roryabraham

First, would you please assign @rezkiy37 from Callstack to this issue, per this message?

Second, @rezkiy37 asked some backend-related questions, and I don't know the answer nor have the backend access. Would you help confirm the expected behavior?

[melvin-bot[bot]]

📣 @cubuspl42 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[roryabraham]

I've investigated the bug. Looks like the backend does not overwrite manually entered fields. Actually, a behaviour seems like the backend stops to smart scan a receipt, once an user sends an update of a current report. So, I tested a case when the same receipt I allowed to smart scan fully, another case is to modify a field like amount, merchant and date. For the second case, if I modify a field during smart scanning, the backend returns a status "OPEN", not a "SCANNING" one. Can we confirm that the current behaviour is correct?

I'm actually not sure about this one. Asked in slack here

[roryabraham]

This is expected behavior