App
App copied to clipboard
Expensify
Report previews don’t seem to get updated when you open a workspace chat.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v1.4.32-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @puneetlath Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1706277477200979
Action Performed:
- create a expense report as a employee
- Be offline as a admin
- Submit report as a member
- Check the LHN and report preview
Expected Result:
Report preview and LHN should get updated as "submitted"
Actual Result:
Not updated until the user clicking on the report
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [ ] Android: Native
- [ ] Android: mWeb Chrome
- [ ] iOS: Native
- [ ] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/30adb168-d0f8-4c2e-9398-cc401967f3d2
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01957dcd6d62f41121
- Upwork Job ID: 1752017420030140416
- Last Price Increase: 2024-01-29
Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
I think we can make this a hot pick, I already got some wave issues to get through, I might pick it up if nobody else will in the mean time
Job added to Upwork: https://www.upwork.com/jobs/~01957dcd6d62f41121
Triggered auto assignment to Contributor Plus for review of internal employee PR - @fedirjh (Internal)
@twisterdotcom, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!
Commented here a possible cause of why we're not sending the updated report actions when the workspace chat is opened. I will continue with the investigation today.
I can't reproduce this one. Probably it's fixed with the latest changes. I'm going to apply the retest-weekly label.
Just encountered it on MacOS version v1.4.35-7 with a scheduled submit report. I think you could probably repro using these instructions:
- Create expense on Collect workspace with Scheduled Submit enabled to daily
- Scan receipt in workspace chat
- Wait a day
- Report will scheduled submit
- Report preview will not update until you click into it
@marcochavezf @twisterdotcom @fedirjh this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
I think this error is related to this bugbot I'm hunting https://github.com/Expensify/Expensify/issues/366360, with the added logs I will work on a fix today
I noticed when a report is submitted via scheduled submit, we're not sending the notification here because of insufficient permission when calling GetAccountIDsByEmails using the harverster authToken.
Created a PR to fix the harvester authToken issue. Seems the bugbot issue is not related to the schedule submit.
@marcochavezf @twisterdotcom @fedirjh this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!
Fixing SSDos locally https://expensify.slack.com/archives/C03TQ48KC/p1708384890886629 to try to reproduce it
Waiting to be re-tested per retest-weekly label. Meanwhile I will move it to weekly cc @m-natarajan
@marcochavezf @twisterdotcom @fedirjh this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!
Hi @mvtglobally just to be sure about the reproducible issue, in the video from the OP the report preview is updated with the Settlement button for the admin after they came back from offline, and I think that's expected because otherwise the Submit button should appear indicating the report hasn't been submitted, no?
I followed the steps from the OP and I'm not really sure what's missing here. The report preview and LHN are updated:
https://github.com/Expensify/App/assets/6829422/385a006d-15cd-4281-8db1-e0b58a5dff23
https://github.com/Expensify/App/assets/6829422/6e3032e5-fa1d-49ad-bbc5-ae02b32c6d4e
From the expected behavior in the OP we mention:
Report preview and LHN should get updated as "submitted"
But we're updating the report preview with the Settlement button (we show either Pay or Approve depending on the policy settings), and in the LHN we show "{policy} owes {amount}" not submitted.
Discussed here about closing it since instructions for expected output are not clear and the report preview issue hasn't happened lately. We can re-open or create another issue if another similar problem occurs.