App
App copied to clipboard
Expensify
[$500] Backend doesn't search for workspace chat
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v1.4.32-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @puneetlath Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1706196526990119
Action Performed:
1.Search for a workspace chat which is existing
Expected Result:
workspace chat appears in the result for the searched user
Actual Result:
Doesn’t show up when I search
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [ ] Android: Native
- [ ] Android: mWeb Chrome
- [ ] iOS: Native
- [ ] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~014eeff4c475cb3811
- Upwork Job ID: 1750944985884672000
- Last Price Increase: 2024-01-26
Job added to Upwork: https://www.upwork.com/jobs/~014eeff4c475cb3811
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)
Current assignee @allroundexperts is eligible for the Internal assigner, not assigning anyone new.
@johncschuster, @allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Looks like this one is internal. We'll need someone to pick this up. Let me see if I can link this to a wave... 🤔
I feel like wave7 as this can affect approvers. That's where it affected me.
It sounds like this could fit into wave5/6/7, so I've raised it in #engineering. If necessary, I'll start pinging folks from those waves.
@johncschuster @allroundexperts this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
@johncschuster, @allroundexperts Whoops! This issue is 2 days overdue. Let's get this updated quick!
@johncschuster, @allroundexperts 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
Hmm... I'm not sure we're still experiencing this behavior. When I search for an existing chat now, I see it returned pretty quickly. @puneetlath, are you still experiencing this?
The back-end search will only happen if you don't already have the chat locally. For example, here is me searching for you. I believe there should be a workspace chat returned since you are part of the NewDot test policy which I'm the approver on.
@johncschuster @allroundexperts this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!
@johncschuster, @allroundexperts Huh... This is 4 days overdue. Who can take care of this?
Thanks @puneetlath! It sounds like this issue persists. I'm going to bump individual curators of waves to see if I can get this slotted in.
@johncschuster @allroundexperts this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!
I've had a chat with some folks, and I think wave7 is the place for this. @Christinadobrzyn / @RachCHopkins do you agree? If so, can we slot this in so we can get some eyes on it?
I'm not 100% sure if this is Wave 7 - Rach would probably know more, I think this might be vip-vsb as it relates to chat.
Hey folks! I've had a chat with Puneet, and while I'm not 100% sure about where this fits in, I completely trust his gut that it fits into wave7 and I've added it to the project tracker.
Interesting, while the backend does return the expense chat in the result, we don't display it most likely because the report name doesn't include submitter?
I think the solution here might be to update our frontend code to search for participants and not just report name
https://github.com/Expensify/App/assets/9680864/9a39b273-3547-4ecb-aaf1-b71a47037c4f
Removing Internal as this isn't a backend issue.
Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new.
@johncschuster it is not clear what we are eyeing here b/c when I search for a workspace chat it appears; even after clearing Onyx it shows up in search results
@FitseTLT have you searched for it using the current user's email? or report name?