App
App copied to clipboard
Expensify
[HIGH] Allow submitting reports which have smartscanning expenses on them
Problem
Coming from here cc @yuwenmemon
In OldDot world, we did not allow to submit a report which had an expense/ receipt still being smartscanned. This error is thrown here.
In NewDot, we are taking different approach for such expenses. For example in PayMoneyRequest, we move such transactions over to a new report. We would like to do the same when report is submitted.
Solution
Similarly to the PayMoneyRequest, if there are smartscanning receipts, move those expenses to a new Open/Processing report (depending on the policy settings), move over the report actions and push updates to the client.
These updates should provide:
- new report
- updated transactions
- updated report actions
- new report preview for the new report
In OldDot, per this comment from @trjExpensify, we should detect if any expenses are smartscanning in Web and show a confirmation modal if the user wants to wait with submission or proceed while creating a new report.
Triggered auto assignment to @sonialiap (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
So it looks like we hit the user with modal inception when they try to take this action:
Dismissing that reveals this:
So I'd vote we don't show the first one, and tweak that copy of the second one:
Not so fast! SmartScan still in progress. [Illustration]
The receipt will be moved to a different open report if you proceed with this action. You can otherwise wait for it finish, or manually edit the receipt by clicking on "Fill out the details".
[Tip: SmartScan your receipts at the register using our mobile app and they'll be done before you submit your report!]
[Submit] [Cancel]
Interested in looking into this! @mountiny do you think this still needs to be a Weekly issue?
@jasperhuangg you're working on this correct? If so can we remove the hot pick label?
@jasperhuangg Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@jasperhuangg Huh... This is 4 days overdue. Who can take care of this?
@trjExpensify yes! sorry, I've been prioritizing another HIGH priority issue I have and have also been looking into a fire. Looking to get started on this next week.
@jasperhuangg Whoops! This issue is 2 days overdue. Let's get this updated quick!
I looked into the code and design docs a bit and sent this in Slack asking for some clarification on my plan for tackling this issue.
Have some local changes, the changes are proving to be a bit more complex than I had imagined because we have to take into account updating the previousReportActionIDs of all the money request actions that are moved to the newly created expense report.
It's been clarified here that the Auth changes aren't necessary anymore. We only need to make the Web-E changes outlined here
@jasperhuangg Huh... This is 4 days overdue. Who can take care of this?
We're still on HOLD for the changes in https://github.com/Expensify/Expensify/issues/359760
@jasperhuangg Whoops! This issue is 2 days overdue. Let's get this updated quick!
@jasperhuangg Whoops! This issue is 2 days overdue. Let's get this updated quick!
@jasperhuangg Whoops! This issue is 2 days overdue. Let's get this updated quick!