App
App copied to clipboard
Expensify
[$500] Web - Chat - New chat user's profile page accessible in offline mode
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.30-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4209291&group_by=cases:section_id&group_order=asc&group_id=229067 Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
- Navigate to staging.new.expensify.com & log in
- Disable the internet connection
- Search for a user that you have not opened a conversation with
- Click the header of the conversation (Note: Cursor is enabled & can open profile page)
- Click on the display of the user in welcome message text ((Note: Cursor is enabled & can open profile page)
- Create a group chat with the user
- Click on the header of the group chat
- Click on the avatar of the user
Expected Result:
User should not be able to open the profile page of a user that has never had a conversation with while offline. The profile should not be accessible in the different areas were it can be accessed by (1:1 header, welcome message, group participants, etc)
Actual Result:
New chat user's profile page can be accessed in offline mode
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [ ] Android: Native
- [ ] Android: mWeb Chrome
- [ ] iOS: Native
- [ ] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/11493b3c-69c2-440a-a2d8-9f1f2f2f9bd2
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01b4b80006f3020fc7
- Upwork Job ID: 1749841957169209344
- Last Price Increase: 2024-01-30
Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Job added to Upwork: https://www.upwork.com/jobs/~01b4b80006f3020fc7
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)
We think that this bug might be related to #vip-split-p2p-chat-groups CC @gabrielessner
Thanks for attempting to reproduce it, @abzokhattab. I've added the retest-weekly label to the issue so we can have it run through QA testing.
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@johncschuster @ntdiary this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@johncschuster, @ntdiary Whoops! This issue is 2 days overdue. Let's get this updated quick!
@johncschuster @ntdiary this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@johncschuster, @ntdiary Eep! 4 days overdue now. Issues have feelings too...
@johncschuster Issue is still reproducible!
https://github.com/Expensify/App/assets/93399543/0bc6e892-0e5a-4ea1-aaf2-5dc195ef764d
@johncschuster @ntdiary this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:
- Decide whether any proposals currently meet our guidelines and can be approved as-is today
- If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
- If you have any questions, don't hesitate to start a discussion in #expensify-open-source
Thanks!
Current assignee @ntdiary is eligible for the Internal assigner, not assigning anyone new.
@johncschuster, @ntdiary Huh... This is 4 days overdue. Who can take care of this?
@johncschuster, @ntdiary Huh... This is 4 days overdue. Who can take care of this?
It seems like we haven't received a proposal yet.
Hello @ntdiary, @johncschuster. Can someone please confirm if my observations are true, If you see the attached video below, we can find that when we are offline, and if we search for a user that isn't in the recently searched list (or loaded), we are unable to open user profile. I'm guessing that this is the correct functionality.
Whereas, if we search for a user that was previously loaded when we were online (even though we might not have had a conversation with the user), we can see that we are able to open the user profile. This is the bug. I'm not sure if this is the expected behavior or if we even want to disable the loading of user profile for users that are already loaded in search.
https://github.com/Expensify/App/assets/58304531/117c2384-2eb3-4f57-aca5-3b52a777ad8a
📣 @srisri332! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:
- Make sure you've read and understood the contributing guidelines.
- Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
- Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
- Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Contributor details Your Expensify account email: [email protected] Upwork Profile Link: https://www.upwork.com/freelancers/~013c4382c91420069f#
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
I'm also not sure what the expected behavior is. So far, with two accounts, I got different actual result: 🥲
-
If we search for a new user and open the report while offline, we can't access the profile page, but once we're back online, we can access it. And then, if we go offline again, search again, and reopen the same report, we're always allowed to access the profile page.
-
We always can't access the profile page while offline.
I'm also not sure what the expected behavior is. So far, with two accounts, I got different actual result: 🥲
If we search for a new user and open the report while offline, we can't access the profile page, but once we're back online, we can access it. And then, if we go offline again, search again, and reopen the same report, we're always allowed to access the profile page.
demo-1.mp4We always can't access the profile page while offline.
demo-2.mp4
Hello @ntdiary, this is what I've observed. Sometimes it tags the account as hidden and sometimes it behaves the way you showed in the first point. I was rereferring to the behavior shown in the first point but I've observed the second one too. I'll try to see if I can come up with a root-cause-analysis and a satisfactory proposal to fix this. Thank you for sharing the details.
@johncschuster, @ntdiary Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!