App icon indicating copy to clipboard operation
App copied to clipboard

[$500] [MEDIUM] mweb - In employee WS, opening an expense detail page and tapping back, page gets scrolled.

Open kbecciv opened this issue 1 year ago β€’ 57 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.25-4 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Tap on employee Workspace chat with lot of expenses
  3. Tap on any IOU to open detail page
  4. Tap back button and note page gets scrolled
  5. Tap back button again and note page gets scrolled

Expected Result:

When in employee WS, opening an expense detail page and tapping back, page must not get scrolled.

Actual Result:

When in employee WS, opening an expense detail page and tapping back, page gets scrolled.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Native
  • [x] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/e46302a2-9ac7-467f-bef4-c4f2449d2847

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01122bfdd943c30cad
  • Upwork Job ID: 1747243693339979776
  • Last Price Increase: 2024-03-01

kbecciv avatar Jan 16 '24 13:01 kbecciv

Job added to Upwork: https://www.upwork.com/jobs/~01122bfdd943c30cad

melvin-bot[bot] avatar Jan 16 '24 13:01 melvin-bot[bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] avatar Jan 16 '24 13:01 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

melvin-bot[bot] avatar Jan 16 '24 13:01 melvin-bot[bot]

I tried to produce this issue and it it showing the same.

Ykumar1415 avatar Jan 16 '24 14:01 Ykumar1415

πŸ“£ @Ykumar1415! πŸ“£ Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

melvin-bot[bot] avatar Jan 16 '24 14:01 melvin-bot[bot]

No proposals yet

situchan avatar Jan 18 '24 19:01 situchan

Not overdue

CortneyOfstad avatar Jan 22 '24 15:01 CortneyOfstad

Not overdue...

CortneyOfstad avatar Jan 22 '24 21:01 CortneyOfstad

πŸ“£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πŸ’Έ

melvin-bot[bot] avatar Jan 23 '24 16:01 melvin-bot[bot]

Still looking for proposals

situchan avatar Jan 25 '24 14:01 situchan

Same

situchan avatar Jan 29 '24 14:01 situchan

@CortneyOfstad @situchan this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Jan 30 '24 15:01 melvin-bot[bot]

πŸ“£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πŸ’Έ

melvin-bot[bot] avatar Jan 30 '24 16:01 melvin-bot[bot]

Not overdue – still waiting on proposals.

CortneyOfstad avatar Jan 31 '24 16:01 CortneyOfstad

@kbecciv can we confirm if the issue is still taking place?

CortneyOfstad avatar Feb 05 '24 14:02 CortneyOfstad

We cannot check the issue, because when user is tapping back button, user navigated to LHN.

https://github.com/Expensify/App/assets/93399543/4d02c0e2-ca54-485c-93bc-589442e59b43

kbecciv avatar Feb 05 '24 19:02 kbecciv

@CortneyOfstad @situchan this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

melvin-bot[bot] avatar Feb 06 '24 15:02 melvin-bot[bot]

@situchan correct me if I am wrong, but based on @kbecciv's comment here, it is working as intended now? I feel like it is but want a buddy check. Thanks!

CortneyOfstad avatar Feb 06 '24 15:02 CortneyOfstad

After ideal nav, there's navigation bug - all back button press goes to LHN whatever current page is. So not able to test for now. I think we should hold this for https://github.com/Expensify/App/issues/35626

situchan avatar Feb 06 '24 15:02 situchan

πŸ“£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πŸ’Έ

melvin-bot[bot] avatar Feb 06 '24 16:02 melvin-bot[bot]

Sounds good @situchan β€” updated the title and changed frequency πŸ‘

CortneyOfstad avatar Feb 08 '24 16:02 CortneyOfstad

It shows that the on-hold issue is scheduled for payment on 2/20 (pending any regressions) so will keep an eye on that πŸ‘

CortneyOfstad avatar Feb 15 '24 19:02 CortneyOfstad

Alright, @situchan the on-hold issue has been resolved β€” can you confirm if you're able to test? And if so, can you provide an update by EOD tomorrow? Thank you!

CortneyOfstad avatar Feb 22 '24 19:02 CortneyOfstad

πŸ“£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πŸ’Έ

melvin-bot[bot] avatar Feb 23 '24 16:02 melvin-bot[bot]

yes still reproducible

https://github.com/Expensify/App/assets/108292595/53fffee6-bff6-41e6-9d49-c0be450efd09

situchan avatar Feb 23 '24 16:02 situchan

Thank you @situchan!

CortneyOfstad avatar Feb 23 '24 17:02 CortneyOfstad

Per the comment here, going to add this to Wave 6. Puneet confirmed this would be "medium" so adjusted the frequency πŸ‘

CortneyOfstad avatar Feb 26 '24 16:02 CortneyOfstad

Reaching out to Callstack here.

CortneyOfstad avatar Feb 26 '24 16:02 CortneyOfstad

@CortneyOfstad Are we still accepting proposals here?

hussnainhamid1 avatar Feb 26 '24 16:02 hussnainhamid1

πŸ“£ @hussnainhamid1! πŸ“£ Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

melvin-bot[bot] avatar Feb 26 '24 16:02 melvin-bot[bot]