[$500] Android - Chat - Chat flickers if a PDF was previously sent or when a new one is sent

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.25-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

1. Open the app
2. Navigate to any chat
3. Tap on ''+'' button
4. Select "Add attachment''
5. Upload a PDF file
6. Check the chat view

Expected Result:

Chat view should not flicker when there are previously sent PDF files or when a PDF file is sent in the chat

Actual Result:

Chat view flickers when there are previously sent PDF file, or when user send a PDF file

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/5b254928-088a-4613-8d32-2ccca2baa4a7

Slack___TEST_ing__3-2023-12-28_22_42_24.367-2024-01-15 16_09_19.026.pdf

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0184552ac59563af4b
• Upwork Job ID: 1746946018928300032
• Last Price Increase: 2024-01-29

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~0184552ac59563af4b

[melvin-bot[bot]]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[Ykumar1415]

I Tried to produce the issue and followed below actions : Open the app Navigate to any chat Tap on ''+'' button Select "Add attachment'' Upload a PDF file Check the chat view

got same response.

[melvin-bot[bot]]

📣 @Ykumar1415! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[trjExpensify]

@sobitneupane do you have a native Android device by any chance?

[sobitneupane]

Nope. I don't have Android device with me.

[melvin-bot[bot]]

@trjExpensify, @sobitneupane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[trjExpensify]

Awaiting proposal review, Melvin!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[sobitneupane]

@trjExpensify I will be able review the issue only in the weekend. Please feel free to re-assign the issue if it's high-priority or urgent.

[trjExpensify]

This weekend is cool!

[melvin-bot[bot]]

@trjExpensify @sobitneupane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot[bot]]

@trjExpensify, @sobitneupane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[trjExpensify]

👋 How'd you get on @sobitneupane over the weekend?

[sobitneupane]

Oops I could not get to it before weekend. I will review it by EOD tomorrow NPT.

[trjExpensify]

Thanks!

[sobitneupane]

@sourcecodedeveloper

I believe the flicker that we are talking about is constant flickering of the pdf thumbnail. Not the change from placeholder thumbnail.

https://github.com/Expensify/App/assets/25876548/e03a12de-8624-4a85-b07b-42d07063a925

The root cause of the issue is the image size is defaulting to width 200 and height 200 after upload and then GetSize() is called after upload which then calculates correct width and height and the image size is adjusted which causes the flicker.

[sobitneupane]

The issue is not reproducible in my end.

https://github.com/Expensify/App/assets/25876548/7cab69e3-bfde-4c28-a0aa-ada59c0ccbd0

[trjExpensify]

Okay, I'm happy to close this out then! I'm sure if it comes back someone will flag it. :)

[kbecciv]

Issue is reproduced on build 1.4.38.0

https://github.com/Expensify/App/assets/93399543/5f39df6e-b757-426f-975b-6b13765531ed

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[trjExpensify]

Hm, so @sobitneupane I think we need to have someone get to the bottom of this. It might not be reproducible 100% of the time, or more so, it takes a few attachments for the bug to appear.

[melvin-bot[bot]]

@trjExpensify @sobitneupane this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot[bot]]

Current assignee @sobitneupane is eligible for the Internal assigner, not assigning anyone new.

[trjExpensify]

Cool, @sobitneupane if you could give this a review please. Thanks!

(Internal: Adding this to #vip-vsb as a LOW chat attachment bug to fix)

[sobitneupane]

@kbecciv In which android version was the issue reproduced?

[sobitneupane]

@sourcecodedeveloper I am trying to reproduce the issue on my end. I could not reproduce the issue on Android Version 8 (real device). Did you reproduce it in simulator or real device? Is the issue reproducible only on uploading an attachment or is it reproducible even with existing attachments?

I would store the attachment width and height in Onyx,

So, we need to store attachment width and height for all the attachments, right? It doesn't feel like an optimal solution. May be if we can pin point the exact root cause, we can get better solution. But I am not sure if it is worth it as market share of Android 7.0 or less is less than 5%.

[trjExpensify]

• The latest version of Android is 14.0
• This bug is apparently only reproducible on versions 10.0 and below?
• @kbecciv did you get confirmation what version this was tested and reported on?