Build additional screens for engagement modal

[marcaaron]

E/E Issue: https://github.com/Expensify/Expensify/issues/356387

New Feature

Add a step to the "Manage my team's expenses" flow which lists functionality currently unavailable in NewDot and asks the user if they need any of those features. If they do we push back to OldDot, if they don't we create the NewDot workspace.

Here is the flow we've landed on:

• User chooses "Manage my team's expenses" on the engagement modal
• User sees this screen:

If they choose "no" they follow the same flow currently in place for users choosing "Manage my team's expenses" If they choose "yes" we show this screen to set redirect expectations:

[Dharani-Eswaramurthi]

This can be done by using a simple state variable.

[melvin-bot[bot]]

📣 @Dharani-Eswaramurthi! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot[bot]]

📣 @sainath998! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[sainath998]

Contributor details Your Expensify account email: [email protected] Upwork Profile Link: https://www.upwork.com/freelancers/~016b509f418e83c65a

[melvin-bot[bot]]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot[bot]]

@marcaaron Whoops! This issue is 2 days overdue. Let's get this updated quick!

[teneeto]

Hi, I'm Eto from Callstack - expert contributor group - and I would like to assist on this issue.

[sainath998]

Hi,

Is this task assigned to me?

On Wed, 17 Jan 2024 at 3:03 PM, Etotaziba Olei @.***> wrote:

Hi, I'm Eto from Callstack - expert contributor group - and I would like to assist on this issue.

— Reply to this email directly, view it on GitHub https://github.com/Expensify/App/issues/34468#issuecomment-1895427616, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASF6WTUFDLBF6ARHEA4EKKTYO6LH3AVCNFSM6AAAAABBY3OF22VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJVGQZDONRRGY . You are receiving this because you were mentioned.Message ID: @.***>

[marcaaron]

Backend PRs in review now. Asking design for the assets. Then we should be ready to go.

[dubielzyk-expensify]

Here's the illustration asset. Let me know if there's anything else needed.

olddot-wireframe.svg.zip

[marcaaron]

@sainath998 no it's not assigned to you, thanks

[marcaaron]

We are waiting for:

• [x] This PR to get merged
• [x] This PR to reach staging

I will give another update when that's all done (since it means there are no more blockers for this issue).

@teneeto if you want to start working on some of the screens without having those parts at this point I think you could.

[teneeto]

Yes @marcaaron, I already started looking for a way out, thanks for the heads-up.

[marcaaron]

Still waiting for the Web-E PR to hit production and the App PR to get merged.

@teneeto if you want I think you could start working on this and set the base branch to the PR that is looking close to merge here? I am guessing it will be merged either today or tomorrow.

[teneeto]

Yea, this works took too

[melvin-bot[bot]]

@teneeto, @marcaaron 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[marcaaron]

@teneeto How's it going with this one? Let me know if I can answer any questions.

[teneeto]

Hi @marcaaron, I'm actually done with the checks on the list i shared on slack. except for translations.

Also, what should be the redirect expectation for the last screen - should we redirect to olddot? and for clarity - what would that link be?

[marcaaron]

Thanks @teneeto I think we resolved that last question.

I have begun testing (code looks great) and left some initial design notes. But maybe @dubielzyk-expensify wants to take another look to make sure everything is 👌.

[dubielzyk-expensify]

Just commented. I've added myself as a reviewer just to ensure that the design is correct (though @marcaaron seems to have most things covered 😄 )

[teneeto]

Thanks for the brilliant reviews guys. Had a second look too, I have resolved all review comments. Let me Know if i'm still missing something.

[marcaaron]

Merged. Great work everyone! 🙇 Thanks for all the help.

[teneeto]

I added a follow-up PR approved and merged.

This PR added a few fixes based on these comments:

1. https://github.com/Expensify/App/pull/35019#discussion_r1482393049
2. https://github.com/Expensify/App/pull/36144#issuecomment-1934190940
3. PR Description

cc @marcaaron

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.39-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/35019
• https://github.com/Expensify/App/pull/36144

If no regressions arise, payment will be issued on 2024-02-19. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @teneeto does not require payment (Contractor)

[melvin-bot[bot]]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[melvin-bot[bot]]

@teneeto, @marcaaron Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot[bot]]

@teneeto, @marcaaron Eep! 4 days overdue now. Issues have feelings too...

[marcaaron]

This one can be closed. I reviewed and there was no C+.