App icon indicating copy to clipboard operation
App copied to clipboard

[ECard Settings] Wallet - Clicking on Address does nothing after submitting empty phone number

Open kavimuru opened this issue 1 year ago • 10 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v1.4.24-7 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

  1. Log in to [email protected]
  2. Go to Settings > Wallet > Expensify card.
  3. Click Reveal details > Update address > Save.
  4. Click Get physical card.
  5. Enter invalid phone number > Next.
  6. Click Get physical card.
  7. Click Address. Note that you can open Address page.
  8. Return to previous page.
  9. Click Phone number > Clear phone number field > Next.
  10. Return to previous page.
  11. Click Address.

Expected Result:

Address page opens.

Actual Result:

Nothing happens when clicking Address.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [x] Android: Native
  • [x] Android: mWeb Chrome
  • [x] iOS: Native
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/43996225/f3cd7235-644d-4fc6-9889-af68942d35a4

View all open jobs on GitHub

kavimuru avatar Jan 12 '24 10:01 kavimuru

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] avatar Jan 12 '24 10:01 melvin-bot[bot]

@kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Jan 15 '24 17:01 melvin-bot[bot]

@kevinksullivan Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Jan 17 '24 17:01 melvin-bot[bot]

@kevinksullivan Still overdue 6 days?! Let's take care of this!

melvin-bot[bot] avatar Jan 19 '24 17:01 melvin-bot[bot]

@grgia assigning you for initial review, then let's pass this off to a contributor that's been involved.

kevinksullivan avatar Jan 24 '24 23:01 kevinksullivan

Going to see if the callstack will take this one

grgia avatar Jan 26 '24 23:01 grgia

asked here

grgia avatar Jan 29 '24 22:01 grgia

@kevinksullivan @grgia this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

melvin-bot[bot] avatar Feb 02 '24 15:02 melvin-bot[bot]

@kevinksullivan, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Feb 02 '24 15:02 melvin-bot[bot]

I am Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this job!

pac-guerreiro avatar Feb 05 '24 23:02 pac-guerreiro

@kevinksullivan, @grgia 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] avatar Feb 06 '24 15:02 melvin-bot[bot]

@grgia @kavimuru What's the password for the user [email protected] ?

pac-guerreiro avatar Feb 07 '24 17:02 pac-guerreiro

@kevinksullivan, @grgia 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

melvin-bot[bot] avatar Feb 08 '24 15:02 melvin-bot[bot]

Thanks for the patience @pac-guerreiro, assigning now!

grgia avatar Feb 08 '24 20:02 grgia

What's the password for the user [email protected]

@pac-guerreiro you don't need access to this account (we don't give out expensifail passwords), but you should be able to test the form flow bugs in DEV

grgia avatar Feb 08 '24 20:02 grgia

@kevinksullivan @grgia @pac-guerreiro this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

melvin-bot[bot] avatar Feb 09 '24 15:02 melvin-bot[bot]

Job added to Upwork: https://www.upwork.com/jobs/~010bd5f5e3f107d6c2

melvin-bot[bot] avatar Feb 09 '24 15:02 melvin-bot[bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

melvin-bot[bot] avatar Feb 09 '24 15:02 melvin-bot[bot]

@grgia Ok, but I'm not able to replicate the exact behaviour because I don't have a valid card, I can only mock it. Nonetheless, from my tests it seems to work!

pac-guerreiro avatar Feb 09 '24 15:02 pac-guerreiro

@kevinksullivan, @rushatgabhane, @grgia, @pac-guerreiro Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Feb 13 '24 15:02 melvin-bot[bot]

PR ready, have fun! 😄

https://github.com/Expensify/App/pull/36056

pac-guerreiro avatar Feb 13 '24 22:02 pac-guerreiro

This issue has not been updated in over 15 days. @kevinksullivan, @rushatgabhane, @grgia, @pac-guerreiro eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

melvin-bot[bot] avatar Mar 08 '24 19:03 melvin-bot[bot]

@kevinksullivan could you please attach payment summary 🙇

rushatgabhane avatar Mar 11 '24 23:03 rushatgabhane

payment request here https://staging.new.expensify.com/r/2938310154194899

rushatgabhane avatar Mar 11 '24 23:03 rushatgabhane

Awaiting payment summary from @kevinksullivan

JmillsExpensify avatar Mar 18 '24 15:03 JmillsExpensify

Payment summary:

  • @rushatgabhane C+: $500

kevinksullivan avatar Mar 22 '24 21:03 kevinksullivan

$500 approved for @rushatgabhane

JmillsExpensify avatar Mar 22 '24 21:03 JmillsExpensify