App icon indicating copy to clipboard operation
App copied to clipboard

[$500] Olddot app - User isn't redirected to NewDot on mWeb after tapping on "Current Plan" option

Open kbecciv opened this issue 1 year ago • 22 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

  1. Sign Out from NewDot on Mobile Web
  2. Open the OldDot mobile app
  3. Log in using an Expensifail account that has an existing workspace policy
  4. Navigate to Settings
  5. Tap on "View all" in the policies section
  6. Navigate to Group Tab
  7. Tap on the "Edit" button next to a workspace
  8. Tap on the "Current Plan" option inside the workspace settings

Expected Result:

Redirection to NewDot on mWeb should occur.

  • The user is redirected to NewDot on mWeb with the correct workspace settings page open.
  • The same user is logged in to NewDot as in the OldDot app.

Actual Result:

User isn't redirected to NewDot on mWeb after tapping on "Current Plan" option in Classic app.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [x] Android: Native
  • [ ] Android: mWeb Chrome
  • [x] iOS: Native
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/dd9f3756-3084-4832-ae44-123cce0f802a

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01efb58f0374bca957
  • Upwork Job ID: 1745466603939237888
  • Last Price Increase: 2024-02-01

kbecciv avatar Jan 11 '24 15:01 kbecciv

Job added to Upwork: https://www.upwork.com/jobs/~01efb58f0374bca957

melvin-bot[bot] avatar Jan 11 '24 15:01 melvin-bot[bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] avatar Jan 11 '24 15:01 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

melvin-bot[bot] avatar Jan 11 '24 15:01 melvin-bot[bot]

Issue found when executing TR https://expensify.testrail.io/index.php?/tests/view/4165557

kbecciv avatar Jan 11 '24 15:01 kbecciv

This should go internal since in order to fix the issue it will require changes within OD codebase.

ikevin127 avatar Jan 12 '24 20:01 ikevin127

@johncschuster, @eVoloshchak Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] avatar Jan 16 '24 17:01 melvin-bot[bot]

Sorry I missed your comment, @ikevin127. I'll change this to Internal.

johncschuster avatar Jan 17 '24 14:01 johncschuster

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

melvin-bot[bot] avatar Jan 17 '24 14:01 melvin-bot[bot]

Hi @kbecciv, I see in the video you're tapping on a Control policy, but we don't support Control policies in NewDot yet, do you know if this only happens to Control policies or also in other policies?

marcochavezf avatar Jan 17 '24 23:01 marcochavezf

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Jan 18 '24 16:01 melvin-bot[bot]

No update, we'd need to confirm if it's happening in collect policies

marcochavezf avatar Jan 19 '24 01:01 marcochavezf

@kbecciv can you please test if this happens with a non-Control policy?

johncschuster avatar Jan 23 '24 22:01 johncschuster

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Jan 25 '24 16:01 melvin-bot[bot]

No update

marcochavezf avatar Jan 25 '24 16:01 marcochavezf

Not overdue, same as in https://github.com/Expensify/App/issues/34370#issuecomment-1897497687 @kbecciv, could you verify this is happening with a non-Control policy? Thanks!

eVoloshchak avatar Jan 29 '24 10:01 eVoloshchak

It happened on both - Collect and Control Policies.

https://github.com/Expensify/App/assets/93399543/45556b54-f713-4473-829c-d363311dc6af

kbecciv avatar Jan 31 '24 23:01 kbecciv

I wonder if this should be part of a wave

marcochavezf avatar Feb 01 '24 01:02 marcochavezf

Asked here

marcochavezf avatar Feb 01 '24 01:02 marcochavezf

@johncschuster @marcochavezf @eVoloshchak this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

melvin-bot[bot] avatar Feb 01 '24 15:02 melvin-bot[bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Feb 01 '24 16:02 melvin-bot[bot]

It sounds like this might be related to wave9. Asking in that channel (here).

johncschuster avatar Feb 05 '24 23:02 johncschuster

Moving this to wave9 per this comment

marcochavezf avatar Feb 06 '24 00:02 marcochavezf

@johncschuster @marcochavezf @eVoloshchak this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

  • Decide whether any proposals currently meet our guidelines and can be approved as-is today
  • If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

melvin-bot[bot] avatar Feb 08 '24 15:02 melvin-bot[bot]

Current assignee @eVoloshchak is eligible for the Internal assigner, not assigning anyone new.

melvin-bot[bot] avatar Feb 08 '24 15:02 melvin-bot[bot]

No update

marcochavezf avatar Feb 08 '24 20:02 marcochavezf

@johncschuster, @marcochavezf, @eVoloshchak Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Feb 12 '24 15:02 melvin-bot[bot]

No update, wrapping up other daily issues

marcochavezf avatar Feb 12 '24 17:02 marcochavezf

Looking to hand it off while I'm working on other wave issues https://expensify.slack.com/archives/CC7NECV4L/p1707927324969599?thread_ts=1707859616.856679&cid=CC7NECV4L

marcochavezf avatar Feb 14 '24 19:02 marcochavezf

Having issues with the ruby env to install the cocoapod dependencies to run OldDot app

marcochavezf avatar Feb 19 '24 22:02 marcochavezf

I fixed the environment to run OldDot locally, and while I was exploring the code and the flow, I had a doubt about when to redirect (since I don't think we want to redirect all the current Collect/Control users to NewDot). Posted in wave9 channel to gut-check

marcochavezf avatar Feb 20 '24 23:02 marcochavezf