[HOLD for payment 2024-02-07] [$500] iOS - Request money - Capture button overlaps with navigation bar in Add receipt modal

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.24-3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

1. Go to 1:1 DM > + > Request money > Manual.
2. Proceed to confirmation page.
3. Tap 3-dot menu > Add receipt.

Expected Result:

The capture button does not overlap with the navigation bar.

Actual Result:

The capture button overlaps slightly with the navigation bar.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [x] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/02ccd0c7-a70d-4d0a-bac9-f1397e9b7e1a

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0128bc9905dd912e60
• Upwork Job ID: 1745431054881275904
• Last Price Increase: 2024-01-18
• Automatic offers:
• Ollyws | Reviewer | 28118466
• mkhutornyi | Contributor | 28118467

[melvin-bot[bot]]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~0128bc9905dd912e60

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Request money - Capture button overlaps with navigation bar in Add receipt modal

What is the root cause of that problem?

includeSafeAreaPaddingBottom is set to false in StepScreenWrapper because it's not passed from IOURequestStepScan and its default value is false. This prop is redirected to ScreenWrapper which adds/removes bottom safe area padding in iOS. https://github.com/Expensify/App/blob/5fe1c8aee7ed3638767d7ef53298e01b27c5eeec/src/pages/iou/request/step/StepScreenWrapper.js#L46-L51

What changes do you think we should make in order to solve the problem?

pass includeSafeAreaPaddingBottom here: https://github.com/Expensify/App/blob/5fe1c8aee7ed3638767d7ef53298e01b27c5eeec/src/pages/iou/request/step/IOURequestStepScan/index.native.js#L218-L223

[TotheSky0710]

That is not correct!

[melvin-bot[bot]]

📣 @TotheSky0710! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Ollyws]

Will review asap.

[Ollyws]

@mkhutornyi's proposal LGTM. 🎀👀🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[greg-schroeder]

bump for @stitesExpensify to confirm C assignment :)

[melvin-bot[bot]]

📣 @Ollyws 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

📣 @mkhutornyi 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[Ollyws]

Remove the overdue label, Melvin.

[mkhutornyi]

PR is ready

[greg-schroeder]

Merged, awaiting deploy to staging -> prod

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.33-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/35151

If no regressions arise, payment will be issued on 2024-02-07. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment automatic offer (Reviewer)
• @mkhutornyi requires payment automatic offer (Contributor)

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@Ollyws] Determine if we should create a regression test for this bug.
• [ ] [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[greg-schroeder]

Ready to go for payment tomorrow, as both offers are accepted.

bump @Ollyws for the checklist and then we can close this out!

[Ollyws]

BugZero Checklist:

• [x] The PR that introduced the bug has been identified. Link to the PR:

This seems to have been the behaviour since IOURequestStepScan was implemented.

• [x] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

N/A

• [x] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

N/A

• [x] Determine if we should create a regression test for this bug.

Yes

• [x] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Go to FAB (or 1:1 DM > +) > Request money > Manual
2. Proceed to confirmation page
3. Tap 3-dot menu > Add receipt
4. Verify that the capture button does not overlap with the navigation bar

Do we agree 👍 or 👎

[greg-schroeder]

Paid, added regression test