[$1000] [MEDIUM] IOU - When paying for and sending an IOU at the same time, the error "Hmm.... it's not here"

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.20-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause-Internal Team Slack conversation: @

Action Performed:

1. On the main device, open New Expensify app
2. Log in under account A
3. On the secondary device, open https://staging.new.expensify.com/
4. Log in under account B
5. Under account A, send a manual IOU to account B
6. Under account A, start creating another manual IOU for account B and stop at the last step (sending).
7. Under account B, pay for the IOU and at the same time send an incomplete IOU from user A
8. Under account A, open the last sent IOU

Expected Result:

When user B pays for an IOU and a new IOU is sent to him at the same time, the sent IOU must be registered by the system as a new and unpaid IOU.

Actual Result:

When user B pays for an IOU and sends him a new IOU at the same time, the sent IOU gives the error "Hmm.... it's not here"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/1b5fd513-36aa-4df7-8b25-332752bbc616

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017525474c707a5fe3
• Upwork Job ID: 1741174465896226816
• Last Price Increase: 2024-01-26

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~017525474c707a5fe3

[melvin-bot[bot]]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [x] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [x] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [x] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [x] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [x] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[Christinadobrzyn]

yeah this is a good one - I can reproduce and I think this needs to be considered with Wave 6 - maybe high/medium priority

[brunovjk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When user A pays for an IOU and user B sends him a new IOU at the same time, the sent IOU gives the error "Hmm.... it's not here"

What is the root cause of that problem?

When user B do the second request, we got an "Unique Constraints Violation" error response.

The code treats all "Unique Constraints Violation" errors as DUPLICATE_RECORD here: https://github.com/Expensify/App/blob/1b1eeb81cf1dd3b439b53b94abf4c476c792aa74/src/CONST.ts#L834

What changes do you think we should make in order to solve the problem?

Introduce a new error identifier like UNIQUE_CONSTRAINTS. This distinction will allow accurately handling "Unique Constraints Violation" separately from DUPLICATE_RECORD.

What alternative solutions did you explore? (Optional)

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[Christinadobrzyn]

I'm going to be ooo this week so adding a buddy to monitor while I'm away.

Status- we're reviewing proposals.

[melvin-bot[bot]]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot[bot]]

@kevinksullivan, @Christinadobrzyn, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[kevinksullivan]

@thesahindia any update on reviewing proposals?

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@kevinksullivan @Christinadobrzyn @thesahindia this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[thesahindia]

Sorry for the delay. I won't be able to take this right now. Please reassign.

[situchan]

I can take over

[melvin-bot[bot]]

❌ There was an error making the offer to @situchan for the Contributor role. The BZ member will need to manually hire the contributor.

[kevinksullivan]

assigning @situchan

[melvin-bot[bot]]

@kevinksullivan @Christinadobrzyn @situchan this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[brunovjk]

Proposal

Updated

[situchan]

@brunovjk thanks for the proposal. I think you just explain the symptom in your RCA.

The code treats all "Unique Constraints Violation" errors as DUPLICATE_RECORD, which prevents proper updating of Onyx with failure data.

I'd like to know why this happens

[brunovjk]

@situchan thank you for the review. You are right, I will investigate more.

[Christinadobrzyn]

I'm back, I think we are reviewing proposals? @situchan should we increase the bounty to get more proposals?

[situchan]

yes we can, as no viable proposals yet

[melvin-bot[bot]]

Upwork job price has been updated to $1000

[situchan]

Awaiting proposals

[brunovjk]

~I can no longer reproduce in the last 'main'~

[Christinadobrzyn]

I think this is still an issue in staging - I followed the steps in the original post with two test accounts and I can see that the drafted IOU (that was then submitted) and paid IOU are showing together in the chat as needing to be paid.

[Christinadobrzyn]

I think we're still collecting proposals for this

[Christinadobrzyn]

What's the best next steps with this, as we're not getting many new proposals? Should I reach out to Software Mansion to see if they can take this on or another suggestion?