[$500] [MEDIUM] LHN - Green dot(IOU) disappears from WS conversation in LHN when going offline-online

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.16-3 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause-Internal Team Slack conversation: @

Action Performed:

1. Open New Expensify app
2. Log in with any account
3. Create new workspace
4. Request money on that workspace
5. Go to offline mode and after a few seconds return to online mode

Expected Result:

The IOU green dot must be present in the LHN in any mode of operation until the IOU request is paid or an IOU error occurs.

Actual Result:

The green dot IOU disappears from the LHN if the user goes offline and comes back online.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/de7c4828-3504-493c-8238-2a0a8fa1674b

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019c2e500b47b7def2
• Upwork Job ID: 1738525487918645248
• Last Price Increase: 2024-01-31

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~019c2e500b47b7def2

[melvin-bot[bot]]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot[bot]]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[paultsimura]

First of all, this is not a deploy blocker – it's happening in prod as well:

We're potentially facing the out-of-order Onyx updates again: When coming back online, 2 conflicting responses set report.hasOutstandingChildRequest:

First comes the ReconnectApp that sets it to false via the mergeCollection action:

Second comes the ReconnectToReport, which should set the value to true, but this value is ignored. I suppose it gets overwritten by the mergeCollection from above similar to what was happening in https://github.com/Expensify/App/issues/28737

This particular issue can be fixed by making sure the ReconnectApp returns report.hasOutstandingChildRequest: true (which is correct), but the Onyx issue should be addressed as well.

cc: @Julesssss for the out-of-order updates

[melvin-bot[bot]]

📣 @aim-salam! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[aim-salam]

Contributor details Your Expensify account email: [email protected] Upwork Profile Link: https://www.upwork.com/freelancers/~0165dd5f4e0e952fdd

[melvin-bot[bot]]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot[bot]]

@Christinadobrzyn, @alitoshmatov, @aldo-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Christinadobrzyn]

I think we're reviewing proposals?

[paultsimura]

I'd say we need a look from @Julesssss on https://github.com/Expensify/App/issues/33544#issuecomment-1868286445

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[aldo-expensify]

Considering @paultsimura 's investigation here, I think it may be good to hold on https://github.com/Expensify/App/issues/32583 and check if https://github.com/Expensify/App/pull/32776 fixes this. That PR may help with avoiding fetching outdated Onyx updates.

[Julesssss]

Just back from holiday. I agree with both this and Aldo's hold.

[Christinadobrzyn]

okay! putting on hold until https://github.com/Expensify/App/issues/33544#issuecomment-1874280226 is complete to see if that resolves this issue. Moved this to weekly while we wait

[Christinadobrzyn]

on hold until https://github.com/Expensify/App/issues/33544#issuecomment-1874280226 is complete

[Christinadobrzyn]

PR https://github.com/Expensify/App/pull/32776 is in production

Testing this again based on the steps in the OP - this is still happening.

https://github.com/Expensify/App/assets/51066321/8f6679e7-2cf5-4ee5-a2fc-ec059fd951e1

Should we continue with proposals @aldo-expensify?

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[aldo-expensify]

Should we continue with proposals @aldo-expensify?

yes, I think we should

[alitoshmatov]

No proposals yet, @paultsimura what do you think, can you provide a proposal to this issue?

[Christinadobrzyn]

@alitoshmatov @aldo-expensify should we increase the bounty or is the payment sufficient for this job?

[paultsimura]

@alitoshmatov @Christinadobrzyn I can no longer reproduce this on main. Could you please re-test?

[Christinadobrzyn]

ah yep! I can't reproduce this either. I'll ask QA to test to see if we can close this.

https://expensify.slack.com/archives/C9YU7BX5M/p1706561441435779

[kbecciv]

Issue is reproducible in our end, build 1.4.33.0

https://github.com/Expensify/App/assets/93399543/8e270d75-f98c-4a9e-a5c2-677d09594139

[Christinadobrzyn]

Ah okay, thanks @kbecciv I can reproduce the same thing but if you remove the pin, the green dot will stay. So I think we want to figure out if the green dot or the pin should take precedent or what we want this to look like.

asking the team. https://expensify.slack.com/archives/C01SKUP7QR0/p1706570242136159

[Christinadobrzyn]

Okay, talking with the team https://expensify.slack.com/archives/C01SKUP7QR0/p1706570242136159 - we want this to be the behaviour -

1. Open New Expensify app
2. Log in with any account
3. Create new workspace
4. Verify workspace is pinned
5. Request money on that workspace
6. Verify the workspace has a green dot now that Request Money has been made
7. Go to offline mode
8. Verify the green dot still appears on the workspace with the Request Money
9. Go back online
10. Verify the workspace is Pinned and the green dot has disappeared

Expected result

The green dot should replace the Pin when coming back online (since there is a Request Money) > on the backend the workspace should still be pinned.

So @alitoshmatov & @aldo-expensify I think we do still want to fix this and change it so that the Pin is replaced with a green dot when coming back online. Thoughts?

[alitoshmatov]

That sounds like plan, @paultsimura can you come up with proposal based on the above

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸