App
App copied to clipboard
Expensify
[MEDIUM] Admin “force submit” throws a RBR red dot in the LHN and double messaging
Slack conversation: https://expensify.slack.com/archives/C02MW39LT9N/p1703190155736439?thread_ts=1703187017.215259&cid=C02MW39LT9N
Action Performed:
Pre-testing requirement: Collect workspace type with the isPolicyExpenseChatEnabled NVP set (SO).
- As the admin, go to OldDot and change the scheduled submit frequency to
manuallyfor a workspace - Log back into NewDot as the member (or refresh if you already are in another window) • Verify that the LHN row for the workspace chat includes a GBR green dot for the draft report awaiting submission :white_check_mark:
- Tap the workspace chat row to navigate to the workspace chat view • Verify that the draft report preview component appears in the workspace chat :white_check_mark: • Verify that the draft report preview component in the chat:
- Includes a green
Submitbutton :white_check_mark: - Sign-in as the collect policy admin account, and navigate to the member’s workspace chat in NewDot
- Tap the report preview component of the
draftreport to navigate to the expense report view - Tap the
Submitbutton :x: • Verify the text in the next steps banner updates to reflect the report has been submitted and is awaiting approval: “Waiting for %approverName% to review these requests” :white_check_mark: • Verify a system message is added to the expense report from the admin that reads: “submitted %reportTotal%” :white_check_mark: • Verify a greenApprove/Paybutton appears to approve the report :white_check_mark:
Expected Result:
If an admin "force submits" an expense there's a GBR and one message about the expense submitted
Actual Result:
If an admin "force submits" an expense there's a RBR and multiple messages about the expense submitted
Screenshots/Videos
Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Bug0 Triage Checklist (Main S/O)
- [ ] This "bug" occurs on a supported platform (ensure
Platformsin OP are ✅) - [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
- [ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
- [ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
- [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.
Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)
@mananjadhav @greg-schroeder this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
@mananjadhav @greg-schroeder this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!
@mananjadhav @greg-schroeder this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!
Yeah, sorry about that. I was going through and closing a group of issues in my queue that weren't relevant to our roadmap - I had about ~15 or so open in tabs and closed them all at once. This one and another one were both open from doing the weekly update in the room, so I closed them by mistake alongside the rest
I believe this has been fixed, but it would be good if someone could try to reproduce in staging/prod to make sure we can close this one.
https://github.com/Expensify/App/assets/5201282/898df060-c2c8-48af-a67b-691e847ef8ee
There seems to have another bug where the next step is not automatically updated for the submitter though.
@rlinoz I believe @JmillsExpensify had this issue today.
is your testing account also an admin? The problem happens when the approver is not an admin since we did not support this case in OldDot and currently the submit report command does not allow this for a mere approver.
We were discussing it a bit here
@mananjadhav, @greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick!
Keeping this on my radar if nobody picks it up, been focused on ideal nav these days!
This will continue to be in the update until someone grabs it, hopefully soon!
Started looking into this day, ran into some dev environment issues while trying to reproduce, so didn't get far. Will continue work on it tomorrow.
One question: I made a collect policy on old dot, and when I try to switch scheduled submit to manual I can't actually find where to do that. I followed this help doc but when I go to the reports page there is no scheduled submit option configuration modal, just this:
Did this option get moved somewhere?
Update: okay I was able to get it to switch to manually submit. Restarted my VM and it started working for some reason.
is your testing account also an admin? The problem happens when the approver is not an admin since we did not support this case in OldDot and currently the submit report command does not allow this for a mere approver.
Huh, this is confusing because the issue description says in step 5 Sign-in as the collect policy admin account. Also I feel silly but how do I even make an approver that isn't an admin? Looking at stackoverflow this appears somewhat enlightening, but its not clear for the issue description that there is more setup required here.
Alright I think I was able to figure out how to reproduce this locally. Though my screen isn't exactly what is described in the issue description. I have three users, one admin, two normal workspace members, but in Old Dot under Members > Approval Mode I put one of my non-admin members as the person to submit reports to instead of the admin.