Cannot complete payment request in Expensify

[maddylewis]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.13-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: No Email or phone of affected tester (no customers): [email protected] Issue reported by: Margaret Madelyn Lewis Slack conversation: https://expensify.slack.com/archives/C05RECHFBEW/p1702400726797869

Action Performed:

1. Puneet sends payment request
2. Open chat with Puneet
3. Click Pay with Expensify
4. Right-hand nav menu opens with options to pay with Wallet, Expensify Card, bank account
5. Clicked Chase Checking
6. That gives me the option to delete the bank account and that's all (not use it to send a payment)
7. My wallet cannot be enabled at this time

Expected Result:

Describe what you think should've happened - i should be able to pay the payment request using my bank account or my wallet

Actual Result:

Describe what actually happened - i could not complete the payment in Expensify

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/38016013/b8406dcd-943e-4ffa-85d2-f536a0d54266

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e10d05edd3cf9881
• Upwork Job ID: 1736965034688700416
• Last Price Increase: 2023-12-19

Issue Owner

Current Issue Owner: @youssef-lr

[melvin-bot[bot]]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot[bot]]

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot[bot]]

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01e10d05edd3cf9881

[melvin-bot[bot]]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Ollyws (Internal)

[mallenexpensify]

Def seems like a #vip-split-p2p-chat-groups issue, asking there https://expensify.slack.com/archives/C05RECHFBEW/p1702959659719479

I imagine most of the work is backend related, would you aggree @Ollyws ?

[Ollyws]

Yeah I agree this one should be internal.

[melvin-bot[bot]]

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mallenexpensify]

@neil-marcellini added Engineering because this is part of with #vip-split-p2p-chat-groups and it seems like a significant bug we want to fix. cc @joelbettner and @rafecolton , if either of you want to work on it, since you're working on P2P.

[melvin-bot[bot]]

@Ollyws, @mallenexpensify, @neil-marcellini Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot[bot]]

@youssef-lr @Ollyws @mallenexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[youssef-lr]

@maddylewis from the code I think the only way this could happen is if the bank account you added does not have the state OPEN, when you're back from OOO can you please ping me so we can debug this together?

[melvin-bot[bot]]

@youssef-lr, @Ollyws, @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[maddylewis]

sure, i will try to get to this before eod

[melvin-bot[bot]]

@youssef-lr @Ollyws @mallenexpensify @maddylewis this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[youssef-lr]

@maddylewis just needs to upgrade her wallet to Gold. I think we can close this!

[GabiHExpensify]

@youssef-lr mind clarifying why you re-opened this? is there anything else to do here, or is it all done?

[youssef-lr]

It seems like @maddylewis should have her wallet upgraded automatically but something prevented it, I will check the backend logs today to find out if there are any KYC errors.

[melvin-bot[bot]]

@youssef-lr @Ollyws @mallenexpensify @maddylewis this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

[melvin-bot[bot]]

@youssef-lr, @Ollyws, @mallenexpensify, @maddylewis Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[maddylewis]

kk, let me know if i need to action something on my end :)

[GabiHExpensify]

friendly bump @youssef-lr, any update here?

[youssef-lr]

I tried searching for some logs, but I don't see anything related to when Maddy tried to activate the wallet, I think this should run from a webhook called by Onfido, so it might have happened a while ago and logs are deleted. @coleaeason is there any way to trigger ActivateWallet again?

[maddylewis]

assigning cole for vis

[coleaeason]

I'm reasonably sure if you go to https://new.expensify.com/enable-payments it should route you through the KYC flow again and trigger ActivateWallet

[youssef-lr]

@maddylewis can you try navigating to the link above please? ping me whenever you get to it and I'll check the logs. Thanks!

[MariaHCD]

Coming from https://github.com/Expensify/Expensify/issues/353860#issuecomment-1895334411. I think we'll need to reset the Onfido verification similar to what we did here. The status for Onfido for Maddy's wallet is consider (perhaps because the name scanned from the uploaded document didn't match what was entered?)

[email protected]:~$ getemail.sh 5801774
[email protected]
[email protected]:~$ sudo readdb.sh -line "select bankAccountID, json_extract(additionalData, '$.verifications.externalApiResponses.requestorIdentityOnfido.status') as onfidoResult from bankaccounts where type = 0 and accountid = 5801774"
bankAccountID = 1242416
 onfidoResult = consider

Onfido applicant link here:

[MariaHCD]

This is the query we can use to reset the Onfido verification and set the current step back to the Onfido step. Buddy check please:

UPDATE bankAccounts SET additionalData = JSON_SET(JSON_REMOVE(additionalData, '$.verifications.externalApiResponses.requestorIdentityOnfido'), '$.currentStep', 'OnfidoStep') WHERE bankAccountID = 1242416;

[techievivek]

Looks good to me. 👍