Expensify
[HOLD] [$500] IOS - Bank account - Keyboard pulls up when redirected to BA page after tapping Pay with Expensify
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.4.0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Precondition: The default currency for the workspace is USD.
- Go to the workspace chat from the precondition.
- Create a workspace expense (Manual).
- Tap on the composer.
- Tap Pay with Expensify.
- Tap Business bank account.
Expected Result:
Describe what you think should've happened
Actual Result:
Keyboard pulls up.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [ ] Android: Native
- [ ] Android: mWeb Chrome
- [x] iOS: Native
- [ ] iOS: mWeb Safari
- [ ] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/34f245b2-5bc2-419c-8ba2-bf6f4278138a
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01e85396f1cd4ec884
- Upwork Job ID: 1729490424428687360
- Last Price Increase: 2023-12-05
Job added to Upwork: https://www.upwork.com/jobs/~01e85396f1cd4ec884
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
Bug0 Triage Checklist (Main S/O)
- [ ] This "bug" occurs on a supported platform (ensure
Platformsin OP are ✅) - [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
- [ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
- [ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
- [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)
Proposal
Please re-state the problem that we are trying to solve in this issue.
Keyboard pulls up.
What is the root cause of that problem?
We're not dismissing the keyboard when opening the KYC wall
What changes do you think we should make in order to solve the problem?
Dismiss the keyboard when opening the KYC wall
Alternatively, we can wait until this is done, then set shouldRestoreKeyboard=false to the modal of the add payment method.
What alternative solutions did you explore? (Optional)
If we want to refocus on Composer after the KYCWall close, we can trigger the focus manually after KYCWall closes (without selecting any item), we can do this by modify the onClose callback to have a isItemSelected variable, if it's false, then trigger focusing on the composer manually.
We should hold this for https://github.com/Expensify/App/issues/24452#issuecomment-1712021524
@MitchExpensify, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
Not overdue, On Hold for https://github.com/Expensify/App/issues/24452#issuecomment-1712021524
@MitchExpensify, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@MitchExpensify, @situchan Huh... This is 4 days overdue. Who can take care of this?
@MitchExpensify, @situchan Huh... This is 4 days overdue. Who can take care of this?
On hold https://github.com/Expensify/App/issues/24452#issuecomment-1712021524
On hold https://github.com/Expensify/App/issues/24452#issuecomment-1712021524
On hold https://github.com/Expensify/App/issues/24452#issuecomment-1712021524
Touches paying with a business bank account so wave collect seems most appropriate here
On hold https://github.com/Expensify/App/issues/24452#issuecomment-1712021524
On hold https://github.com/Expensify/App/issues/24452#issuecomment-1712021524
On hold https://github.com/Expensify/App/issues/24452#issuecomment-1712021524