App
App copied to clipboard
Expensify
[HOLD #336130][$500] Workspace chat notifications is ignored for requests
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: Reproducible in staging?: needs reproduction Reproducible in production?: needs reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @quinthar Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1700919080607879
Action Performed:
- Create a workspace in account A
- Click on the new workspace in the LHN > click on the workspace name at the top of the page
- Click on Settings
- Set notification preference for workspace chat to
DailyorMute - Go back to the workspace through the Profile > click Members > Invite member B
- As member B request money from the workspace chat
Expected Result:
Should notify Account A via the standard UnreadMessageSummary logic, which honors the notification preference.
Actual Result:
A is sent an email/text immediately, via a dedicated notification, ignoring the A's workspace chat notification setting.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [ ] Android: Native
- [ ] Android: mWeb Chrome
- [ ] iOS: Native
- [ ] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01055a3f6b1ce74d71
- Upwork Job ID: 1729640666933612544
- Last Price Increase: 2023-11-28
Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Bug0 Triage Checklist (Main S/O)
- [x] This "bug" occurs on a supported platform (ensure
Platformsin OP are ✅) - [x] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
- [x] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
- [x] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
- [x] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
I think I got this right in the OP video (sorry the pixelation is so bad, it's a heavy video). It's true the notifications shouldn't show in the LHN if the settings are set to something other than immediate.
I think this can be external?
Job added to Upwork: https://www.upwork.com/jobs/~01055a3f6b1ce74d71
Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)
@aldo-expensify it looks like you've been working in the product channel on the UnreadMessageSummary. This is what I understand of this behaviour but I don't know if it actually answers @unicorndev-727's above question.
- Unread message can create a notification (
UnreadMessageSummary). These notification are not sent if the workspace setting is set to Mute (or Daily) messages. - Creating/modifying reports/expense can create a different notification. These notifications are always sent.
- We're working on changes if the user doesn't' want to receive the 2nd notification type.
Maybe this should be internal?
Asking for some guidance - https://expensify.slack.com/archives/C03U7DCU4/p1701224698357089?thread_ts=1700867114.980389&cid=C03U7DCU4
@Christinadobrzyn yes, this is internal. Also, I think this falls within the scope of https://github.com/Expensify/Expensify/issues/336130
Current assignee @c3024 is eligible for the Internal assigner, not assigning anyone new.
Awesome! Thanks @aldo-expensify! I'll put this on hold for https://github.com/Expensify/Expensify/issues/336130 just to make sure it's resolved with that job!
still on hold for https://github.com/Expensify/Expensify/issues/336130
still on hold for https://github.com/Expensify/Expensify/issues/336130
I think this may be resolved, the following changes have been made since this was created:
-
Mutenotification preference is respected now, and - The OldDot submit notification is not send anymore if the manager is an account that only uses NewDot (this is checked by looking at the NVP
tryNewDot)
So.. if the workspace admin is a NewDot only user, the only notification that we will send if about "offline activity", but that will be cancelled because the workspace is muted.
Oh great! I'll test this tomorrow! Thanks for the insight @aldo-expensify!
Hey @aldo-expensify I'm not seeing 'notification' preferences in our NewDot workspace - do you know where this exists?
Okay testing this Admin A for me [email protected] Employee [email protected].
Changed notification to daily so I'll see if I get a notification on this tomorrow.
I did receive an email when the workspace was created but it was sent around the same time that I created the workspace. So I don't know if this aligns with our 'daily' frequency. Going to try again by muting the messages.
Testing again...
Okay, testing on [email protected] (admin) and [email protected](member).
I created a workspace and set the notifications as mute.
When the new workspace was created, both users got an email notification about joining the workspace
But there was no message sent about the request money.
@aldo-expensify do you know if this is expected? • Emails about joining a new workspace do not follow the notification rules of a chat? • Request money notifications follow the notification rules?
I think this is correct but can you confirm?
@aldo-expensify do you know if this is expected? • Emails about joining a new workspace do not follow the notification rules of a chat?
I haven't looked into that notification, but considering that the mute is set in the policyExpenseChat of the employee, I think that is not going to be able to prevent this notification from being sent to the admin. That notification goes out before you set it to mute
• Request money notifications follow the notification rules?
Yes, to my understanding this one should follow not be sent because of the mute
@Christinadobrzyn, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Ah okay so it does sound like this is behaving as expected based on https://github.com/Expensify/App/issues/32072#issuecomment-1972202051
Going to close! @aldo-expensify or @c3024 let me know if you think otherwise!