App
App copied to clipboard
[$250] [TS migration] Migrate 'IOUEditRequestReceipt' page to TypeScript
TypeScript migration
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01420471b55c08c38c
- Upwork Job ID: 1750848104777138176
- Last Price Increase: 2024-01-26
- Automatic offers:
- akinwale | Reviewer | 28123473
This issue has not been updated in over 15 days. eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
@abzokhattab @shahinyan11 Have you read Vit message on slack? 😅
dibs Slack
Job added to Upwork: https://www.upwork.com/jobs/~01420471b55c08c38c
Triggered auto assignment to @Christinadobrzyn (NewFeature
), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.
Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External
)
dibs slack
📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
📣 @codinggeek2023 You have been assigned to this job! Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻 Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing 📖
Upwork job price has been updated to $250
Dibs
Done with the application, will get the PR ready well before tuesday :)
@akinwale, @Christinadobrzyn, @codinggeek2023 Whoops! This issue is 2 days overdue. Let's get this updated quick!
I think we're working on the PR for this.
@codinggeek2023 It looks like this is yours? Can you provide a link to the PR for me to follow? Thanks!
hello @Christinadobrzyn , thanks for your patience, yes this is mine, will put up draft PR in an hour :)
Awesome! Thanks @codinggeek2023!
looks like PR is in a draft state https://github.com/Expensify/App/pull/35577
@codinggeek2023 Could you provide an update on how it's going with the PR? Do you have any concerns or questions? Thanks.
@akinwale sorry for the delay, i have put up a PR, I am having some errors in type conversions, can you please review it once?, i have stated comments in particular about the places i'm getting these errors :)
hi @akinwale can you review the PR when you have a moment? Thanks!
@codinggeek2023 Just checking in here. Is the PR ready for final review?
waiting on some final reviews for the camera module :)
just checking on where we are with this @codinggeek2023 and @akinwale- thanks!
Working on suggestions should be ready over the weekend :)
update: waiting on @akinwale for final review :)
IOURequestStepScan
had major changes by a recent PR, we are having merge conflicts in the whole file, will need to remigrate it to typescript :)
I will review tomorrow.
Please review this day after tomorrow,
we are having merge conflicts in the whole file, will need to remigrate it to typescript :)
Major components were changed so have to remigrate few files :)
@akinwale, thanks for the wait, fixed most of it, left few comments too, can you address them when you find time please :)