App icon indicating copy to clipboard operation
App copied to clipboard

[$250] [TS migration] Migrate 'IOUEditRequestReceipt' page to TypeScript

Open melvin-bot[bot] opened this issue 1 year ago • 18 comments

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/EditRequestReceiptPage.js 10
src/pages/iou/ReceiptDropUI.js 8
src/pages/iou/ReceiptSelector/index.native.js 27
src/pages/iou/ReceiptSelector/index.js 30
src/pages/iou/ReceiptSelector/NavigationAwareCamera/index.native.js 4
src/pages/iou/ReceiptSelector/NavigationAwareCamera/index.js 5
src/pages/iou/ReceiptSelector/CameraPermission/index.js 0
src/pages/iou/ReceiptSelector/CameraPermission/index.ios.js 1
src/pages/iou/ReceiptSelector/CameraPermission/index.android.js 1
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01420471b55c08c38c
  • Upwork Job ID: 1750848104777138176
  • Last Price Increase: 2024-01-26
  • Automatic offers:
    • akinwale | Reviewer | 28123473

melvin-bot[bot] avatar Nov 27 '23 16:11 melvin-bot[bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

melvin-bot[bot] avatar Dec 21 '23 11:12 melvin-bot[bot]

@abzokhattab @shahinyan11 Have you read Vit message on slack? 😅

blazejkustra avatar Jan 26 '24 11:01 blazejkustra

dibs Slack

eucool avatar Jan 26 '24 11:01 eucool

Job added to Upwork: https://www.upwork.com/jobs/~01420471b55c08c38c

melvin-bot[bot] avatar Jan 26 '24 11:01 melvin-bot[bot]

Triggered auto assignment to @Christinadobrzyn (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

melvin-bot[bot] avatar Jan 26 '24 11:01 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

melvin-bot[bot] avatar Jan 26 '24 11:01 melvin-bot[bot]

dibs slack

eucool avatar Jan 26 '24 11:01 eucool

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

melvin-bot[bot] avatar Jan 26 '24 12:01 melvin-bot[bot]

📣 @codinggeek2023 You have been assigned to this job! Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing 📖

melvin-bot[bot] avatar Jan 26 '24 12:01 melvin-bot[bot]

Upwork job price has been updated to $250

melvin-bot[bot] avatar Jan 26 '24 12:01 melvin-bot[bot]

Dibs

ghost avatar Jan 26 '24 12:01 ghost

Done with the application, will get the PR ready well before tuesday :)

eucool avatar Jan 26 '24 12:01 eucool

@akinwale, @Christinadobrzyn, @codinggeek2023 Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Jan 29 '24 15:01 melvin-bot[bot]

I think we're working on the PR for this.

Christinadobrzyn avatar Jan 29 '24 20:01 Christinadobrzyn

@codinggeek2023 It looks like this is yours? Can you provide a link to the PR for me to follow? Thanks!

Christinadobrzyn avatar Jan 30 '24 21:01 Christinadobrzyn

hello @Christinadobrzyn , thanks for your patience, yes this is mine, will put up draft PR in an hour :)

eucool avatar Jan 31 '24 17:01 eucool

Awesome! Thanks @codinggeek2023!

Christinadobrzyn avatar Jan 31 '24 18:01 Christinadobrzyn

looks like PR is in a draft state https://github.com/Expensify/App/pull/35577

Christinadobrzyn avatar Feb 05 '24 23:02 Christinadobrzyn

@codinggeek2023 Could you provide an update on how it's going with the PR? Do you have any concerns or questions? Thanks.

akinwale avatar Feb 12 '24 10:02 akinwale

@akinwale sorry for the delay, i have put up a PR, I am having some errors in type conversions, can you please review it once?, i have stated comments in particular about the places i'm getting these errors :)

eucool avatar Feb 12 '24 14:02 eucool

hi @akinwale can you review the PR when you have a moment? Thanks!

Christinadobrzyn avatar Feb 27 '24 01:02 Christinadobrzyn

@codinggeek2023 Just checking in here. Is the PR ready for final review?

akinwale avatar Feb 28 '24 05:02 akinwale

waiting on some final reviews for the camera module :)

eucool avatar Feb 28 '24 20:02 eucool

just checking on where we are with this @codinggeek2023 and @akinwale- thanks!

Christinadobrzyn avatar Mar 13 '24 05:03 Christinadobrzyn

Working on suggestions should be ready over the weekend :)

eucool avatar Mar 14 '24 21:03 eucool

update: waiting on @akinwale for final review :)

eucool avatar Mar 20 '24 13:03 eucool

IOURequestStepScan had major changes by a recent PR, we are having merge conflicts in the whole file, will need to remigrate it to typescript :)

eucool avatar Mar 20 '24 13:03 eucool

I will review tomorrow.

akinwale avatar Mar 20 '24 18:03 akinwale

Please review this day after tomorrow,

we are having merge conflicts in the whole file, will need to remigrate it to typescript :)

Major components were changed so have to remigrate few files :)

eucool avatar Mar 21 '24 00:03 eucool

@akinwale, thanks for the wait, fixed most of it, left few comments too, can you address them when you find time please :)

eucool avatar Mar 24 '24 22:03 eucool