App icon indicating copy to clipboard operation
App copied to clipboard

[$250] [HOLD for payment 2024-02-07] [TS migration] Migrate 'ReportActionItemReportPreview.js' component to TypeScript

Open melvin-bot[bot] opened this issue 1 year ago • 17 comments

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/ReportActionItem/ReportPreview.js 34
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01df7d0f355dcd20c0
  • Upwork Job ID: 1755376801234128896
  • Last Price Increase: 2024-02-07

melvin-bot[bot] avatar Nov 27 '23 16:11 melvin-bot[bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

melvin-bot[bot] avatar Dec 21 '23 11:12 melvin-bot[bot]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

VickyStash avatar Jan 11 '24 09:01 VickyStash

Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] avatar Jan 29 '24 11:01 melvin-bot[bot]

Triggered auto assignment to @jliexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

melvin-bot[bot] avatar Jan 29 '24 23:01 melvin-bot[bot]

We just merged the linked PR for this issue 👏

jasperhuangg avatar Jan 30 '24 00:01 jasperhuangg

Ok cool, so from the PR - is this correct @jasperhuangg ?

Payment Summary:

  • Contributor: @VickyStash $250
  • C+: @situchan $250

https://www.upwork.com/jobs/~01df7d0f355dcd20c0

jliexpensify avatar Jan 30 '24 00:01 jliexpensify

@jliexpensify that looks good to me!

jasperhuangg avatar Jan 30 '24 18:01 jasperhuangg

Cool, looks like we've deployed to Staging, but we generally pay when it's been 7 days since it was deployed to Production. I'll keep an eye out on that and adjust the payment date accordingly.

@situchan anything to complete for the checklist?

jliexpensify avatar Jan 31 '24 07:01 jliexpensify

This doesn't require BZ checklist

situchan avatar Jan 31 '24 09:01 situchan

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] avatar Jan 31 '24 22:01 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.34-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/34374
  • https://github.com/Expensify/App/pull/35361

If no regressions arise, payment will be issued on 2024-02-07. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @VickyStash does not require payment (Contractor)

melvin-bot[bot] avatar Jan 31 '24 22:01 melvin-bot[bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [ ] [@VickyStash] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [ ] [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

melvin-bot[bot] avatar Jan 31 '24 22:01 melvin-bot[bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

melvin-bot[bot] avatar Feb 07 '24 15:02 melvin-bot[bot]

Job added to Upwork: https://www.upwork.com/jobs/~01df7d0f355dcd20c0

melvin-bot[bot] avatar Feb 07 '24 23:02 melvin-bot[bot]

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] avatar Feb 07 '24 23:02 melvin-bot[bot]

@situchan hired you here: https://www.upwork.com/jobs/~01df7d0f355dcd20c0

jliexpensify avatar Feb 07 '24 23:02 jliexpensify

Upwork job price has been updated to $250

melvin-bot[bot] avatar Feb 07 '24 23:02 melvin-bot[bot]

Paid and job closed!

jliexpensify avatar Feb 08 '24 04:02 jliexpensify