App
App copied to clipboard
Expensify
[Pay Jan 24] [$250] [TS migration] Migrate 'ReportActionItemTaskPreview.js' component to TypeScript
TypeScript migration
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files
| Path | Dependencies |
|---|---|
| src/components/ReportActionItem/TaskPreview.js | 31 |
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01c68691eb92360ad3
- Upwork Job ID: 1736777434713346048
- Last Price Increase: 2023-12-25
Issue Owner
Current Issue Owner: @mallenexpensify![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Job added to Upwork: https://www.upwork.com/jobs/~01c68691eb92360ad3
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)
Proposal
Please re-state the problem that we are trying to solve in this issue.
[TS migration] Migrate 'ReportActionItemTaskPreview.js' component to TypeScript
What is the root cause of that problem?
Not problem (Technical ticket )
What changes do you think we should make in order to solve the problem?
We need to update the file using best practices using TS guide
https://github.com/Expensify/App/blob/main/contributingGuides/TS_STYLE.md
What alternative solutions did you explore? (Optional)
NA
My proposal basically would be to convert prop types to a TS type, we could set the default values, destructure the props and remove prop-types from the file.
📣 @gerzonc! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:
- Make sure you've read and understood the contributing guidelines.
- Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
- Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
- Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Contributor details Your Expensify account email: [email protected] Upwork Profile Link: https://www.upwork.com/freelancers/~01021f76b2b5cb843d
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.
Hello, I'm Dmitry, I'd like to work on this issue.
To migrate a JavaScript file to TypeScript:
- Rename the file to .tsx.
- Define types for props using interfaces.
- Remove PropTypes imports and declarations.
- Install TypeScript definitions for libraries.
- Utilize TypeScript's built-in ref and style types.
- Use TypeScript-friendly event types.
- Ensure proper import paths with .tsx.
- Export the function component using export default.
Thank you!
Contributor details Your Expensify account email: [email protected] Upwork Profile Link: https://www.upwork.com/freelancers/~01bf188dd5498d1e42
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
Proposal
Please re-state the problem that we are trying to solve in this issue.
[TS migration] Migrate 'ReportActionItemTaskPreview.js' component to TypeScript
What is the root cause of that problem?
N/a, not a bug
What changes do you think we should make in order to solve the problem?
We need to update these files using best practices using TS guide https://github.com/Expensify/App/blob/main/contributingGuides/TS_STYLE.md
Contributor details Expensify account email: [email protected] Upwork Profile Link: https://www.upwork.com/freelancers/hpsurani
@thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@thesahindia Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!
Triggered auto assignment to @tgolen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
@tgolen, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!
@tgolen, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!
📣 @unicorndev-727 You have been assigned to this job! Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻 Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing 📖