Fix/16184 base options selector refactoring

[Piotrfj]

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/16184 PROPOSAL: https://github.com/Expensify/App/issues/16184#issuecomment-1841781310

Tests

1. Open any place that has options selections, like search page

• [x] Verify that no errors appear in the JS console

Offline tests

1. Open any place that has options selections, like search page

QA Steps

1. Open any place that has options selections, like search page

• [x] Verify that no errors appear in the JS console

PR Author Checklist

• [x] I linked the correct issue in the ### Fixed Issues section above
• [x] I wrote clear testing steps that cover the changes made in this PR
  • [x] I added steps for local testing in the Tests section
  • [x] I added steps for the expected offline behavior in the Offline steps section
  • [x] I added steps for Staging and/or Production testing in the QA steps section
  • [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• [x] I included screenshots or videos for tests on all platforms
• [x] I ran the tests on all platforms & verified they passed on:
  • [x] Android / native
  • [x] Android / Chrome
  • [x] iOS / native
  • [x] iOS / Safari
  • [x] MacOS / Chrome / Safari
  • [x] MacOS / Desktop
• [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• [x] I followed proper code patterns (see Reviewing the code)
  • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • [x] I verified that comments were added to code that is not self explanatory
  • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [x] I followed the guidelines as stated in the Review Guidelines
• [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• [x] I verified that if a function's arguments changed that all usages have also been updated correctly
• [x] If a new component is created I verified that:
  • [x] A similar component doesn't exist in the codebase
  • [x] All props are defined accurately and each prop has a /** comment above it */
  • [x] The file is named correctly
  • [x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • [x] The only data being stored in the state is data necessary for rendering and nothing else
  • [x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • [x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • [x] All JSX used for rendering exists in the render method
  • [x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• [x] If any new file was added I verified that:
  • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [x] If a new CSS style is added I verified that:
  • [x] A similar style doesn't already exist
  • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• [x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/41384305/486fcb63-7805-4d8e-bc5c-8f2cf84e01f6

MacOS: Desktop

https://github.com/Expensify/App/assets/41384305/d5295e81-f91d-4856-9756-14281c691219

[melvin-bot[bot]]

@thienlnam Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[thienlnam]

Hey! Can you please make link the associated issue in the PR description next time? That's required for our automation to auto-assign the correct people to review the PR - thanks!

[thienlnam]

Also, looks like we have some merge conflicts

[shubham1206agra]

@Piotrfj Please see this https://github.com/Expensify/App/blob/85f372c4e35c30119e72c7689959282a298bad1b/contributingGuides/STYLE.md#destructuring

[Piotrfj]

Update: today im on sick leave, have everything almost finished, will provide proposal with fixes tomorrow

[Piotrfj]

Finishing testings today

[koko57]

@Piotrfj FYI: after Theme Switching migration we no longer import styles like this: import styles from '@styles/styles'; we use useThemeStyles hook - you can check how it's done here: https://github.com/Expensify/App/pull/31034/files

[koko57]

@thienlnam @shubham1206agra kindly asking for re-review 🙏🏻

[shubham1206agra]

@thienlnam Should we deprecate the use of shouldDelayFocus prop inside this component? Since we have useAutoFocusInput hook being used in most place already

[koko57]

@shubham1206agra @thienlnam I'm taking over this PR while @Piotrfj is ooo. If you'll request some other changes let me know 🙂

[thienlnam]

@thienlnam Should we deprecate the use of shouldDelayFocus prop inside this component? Since we have useAutoFocusInput hook being used in most place already

Yes that would be great

[shubham1206agra]

@koko57 Can you incorporate the above comment too?

[koko57]

@shubham1206agra ready for re-review 🙂

[koko57]

@shubham1206agra friendly bump 🙂

[shubham1206agra]

@koko57 Please merge main and fix imports

[koko57]

@shubham1206agra merged with main. What's wrong with the imports?

[koko57]

@shubham1206agra done!

[koko57]

@shubham1206agra ready for re-review

[koko57]

@shubham1206agra friendly bump 🙂

[shubham1206agra]

Sorry for the delay. Can you merge main again?

[koko57]

@shubham1206agra done! 🙂

[koko57]

@shubham1206agra I merged once again, please review it

[shubham1206agra]

Oh, I am so sorry. I will review this after https://github.com/Expensify/App/pull/32666 today Thanks for the patience

[shubham1206agra]

https://github.com/Expensify/App/assets/58412969/3d729811-9b2c-49d0-9afe-f151fc40edd6

@koko57 Can you see this problem, and console error too?

[koko57]

@shubham1206agra no I don't have this error. Merged with main

[shubham1206agra]

Another problem was that the list doesn't scroll with up down arrow keys

[Piotrfj]

@shubham1206agra issue with scrolling fixed, please review the changes and if everything is fine, merge :)

[shubham1206agra]

@Piotrfj Can you check the failing test here?

[shubham1206agra]

@Piotrfj bump here ^ And please merge main here

[Piotrfj]

@shubham1206agra merged main, but it had no effect on tests, from what i see the errors are from different modules not related to the refactoring, cant do anything about that