[$1000] Desktop - There is no turning back from the SSO provider portal

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.85-2 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Issue found when executing PR https://github.com/Expensify/App/pull/28372

Action Performed:

1. Configure your account to have SAML enabled but not required in oldDot
   • You can simulate this by manually setting isSAMLEnabled to true here.
2. Enter the email for your account in newDot
3. Confirm you see the option to choose to sign in with SAML or with a magic code
4. Choose the Go Back option and confirm you're dropped back on the sign-in page with your email pre-filled
5. Press Continue
6. Choose the Use Magic Code option and confirm you get a magic code sent to your email
7. Press Go Back and confirm you're back on the sign-in page with your email pre-filled
8. Press Continue
9. Choose Use Single Sign On option
10. Confirm you briefly see an interstitial page about launching your SSO provider's login portal

Expected Result:

There should be a Path back from the SSO provider portal (arrow or cross)

Actual Result:

There is no turning back from the SSO provider portal

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

https://github.com/Expensify/App/assets/78819774/d6d11dca-466e-40d7-badf-24dfde2f71f5

https://github.com/Expensify/App/assets/78819774/2715f95e-1340-4e86-88a8-467c87b5228c

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b86a48a78c5400e9
• Upwork Job ID: 1714380966850781184
• Last Price Increase: 2024-01-31

[melvin-bot[bot]]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01b86a48a78c5400e9

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[NikkiWines]

This will be handled as part of the SAML project - putting a hold on this issue for now

[melvin-bot[bot]]

@anmurali, @0xmiroslav Huh... This is 4 days overdue. Who can take care of this?

[anmurali]

@NikkiWines - can you link the issue you are referring to? And if it makes sense can you degrade this issue to a weekly or monthly?

[NikkiWines]

Sure, it's planned to be handled as part of polish for https://github.com/Expensify/Expensify/issues/294583 (internal link) - though actually I guess there's no reason it can't be handled externally now.

The desktop UI is on production, if someone wants to simulate having a SAML enabled or required account on newDot to trigger the new flow, they'll just need to modify either of these lines to be true instead of reading from account

[melvin-bot[bot]]

Current assignee @anmurali is eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@anmurali @0xmiroslav this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@anmurali @0xmiroslav this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[0xmiroslav]

on hold still

[melvin-bot[bot]]

@anmurali @0xmiroslav this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot[bot]]

Current assignee @0xmiroslav is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot[bot]]

@anmurali, @0xmiroslav Huh... This is 4 days overdue. Who can take care of this?

[NikkiWines]

This can be taken off hold, the desktop SAML flow exists in production now

[anmurali]

Amazing - https://github.com/Expensify/App/issues/29825#issuecomment-1778453846 already has the fix outlined. I will add an external label to this so a contributor can make the change

[melvin-bot[bot]]

Current assignee @0xmiroslav is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[0xmiroslav]

Awaiting proposals

[melvin-bot[bot]]

@anmurali, @0xmiroslav Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@anmurali, @0xmiroslav 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot[bot]]

@anmurali, @0xmiroslav 10 days overdue. I'm getting more depressed than Marvin.

[0xmiroslav]

Still awaiting proposals

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@anmurali, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!