[DISTANCE] LOW: PHASE 2: Wave 5 CLEANUP Refactor navigation among screens related to money request features

[tgolen]

• [ ] Held on https://github.com/Expensify/App/issues/26538

In https://github.com/Expensify/App/issues/26538 Most of the changes were made by adding new components. This eliminated a lot of conflicting headaches from people working on existing components.

Phase 2 is all about removing the original components and any of the duplicated efforts. The tasks that need to be done as part of this issue are:

• [x] Remove iou/ReceiptSelector and copy any changes since Nov 27 into IOURequestStepScan/
• [x] Remove WaypointEditor.js and copy any changes since Nov 27 into IOURequestStepWaypoint.js
• [ ] #34606
• [ ] #34607
• [ ] #34608
• [ ] #34609
• [ ] #34610
• [ ] #34611
• [ ] #34612
• [ ] #34613
• [ ] #34614
• [ ] #34615
• [ ] #34616
• [ ] #34617
• [ ] Remove MoneyRequestConfirmationList.js and copy any changes since Nov 27 into MoneeRequestConfirmationList.js
• [ ] HOLD Edit ROUTES.ts and remove MONEY_REQUEST_* routes, remove "create" from the front of the routes
• [ ] HOLD Edit linkgingConfig.js and remove Money_Request* screens
• [ ] HOLD Edit ModalStackNavigators.js remove old Money_Request* components
• [ ] HOLD Edit IOU.js and remove setMoneyRequest* methods and rename setMoneeRequest to "Money"
• [ ] HOLD Edit IOU.js and remove startMoneyRequest() method and rename startMoneeRequest() to startMoneyRequest()
• [ ] HOLD Edit IOU.js and remove createDistanceRequest() method and use requestMoneyFromDistance() everywhere
• [ ] HOLD Remove ONYXKEYS.IOU
• [ ] HOLD Remove EditRequestPage
• [ ] HOLD Remove EditSplitBillPage

git diff "tgolen-refactor-request-navigation2@{2023-11-15}..main" src/pages/iou/IOUCurrencySelection.js

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b453df445e7dd962
• Upwork Job ID: 1711432700883152896
• Last Price Increase: 2023-10-09

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01b453df445e7dd962

[melvin-bot[bot]]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @ntdiary (Internal)

[tgolen]

This is still mostly on HOLD while I work on phase 1. I updated this issue yesterday to change the date of the last time I checked the files for change, which I also did yesterday.

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @tgolen, @ntdiary eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[tgolen]

This is off hold now and I am bumping it up to daily and will start work on it this afternoon.

[tgolen]

I've been working on cleaning up the receipt selector this week

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @tgolen, @ntdiary eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[tgolen]

I'm working on the second item. Once I have that finished and have two solid examples, I will create issues for all the remaining items and send them out to contributors to help finish the work.

[tgolen]

Today I created a bunch of issues to get the first batch of issues completed. The rest of the items in this list can only be done once all of these components are cleaned up.

[DylanDylann]

@tgolen Coming from: https://github.com/Expensify/App/pull/35137#discussion_r1475730296 Currently, we still use MoneyRequestConfirmationList in SplitBillDetailsPage. Do we have a plan to remove MoneyRequestConfirmationList and use MoneyTemporaryForRefactorRequestConfirmationList instead?

[tgolen]

Yeah, we do. It's one of the checklist items in the issue description. I didn't create an issue for it yet because I was waiting for all the previous components to be finished first (which will help make the cleanup process easier).

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @tgolen, @ntdiary eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[fabioh8010]

Hey @tgolen 👋 I was passing through the remaining JS files and I noticed these ones and this related issue, could you confirm which ones we can migrate?

[DylanDylann]

These pages will be removed soon

[fabioh8010]

@tgolen @DylanDylann I found these JS files too, can we migrate them?

• src/pages/iou/request/IOURequestStartPage.js
• src/pages/iou/request/IOURequestRedirectToStartPage.js
• src/pages/iou/request/step/StepScreenWrapper.js
• src/pages/iou/request/step/StepScreenDragAndDropWrapper.js
• src/pages/iou/request/step/IOURequestStepTaxRatePage.js
• src/pages/iou/request/step/IOURequestStepTaxAmountPage.js
• src/pages/iou/request/step/IOURequestStepTag.js
• src/pages/iou/request/step/IOURequestStepParticipants.js
• src/pages/iou/request/step/IOURequestStepMerchant.js
• src/pages/iou/request/step/IOURequestStepDistance.js
• src/pages/iou/request/step/IOURequestStepDescription.js
• src/pages/iou/request/step/IOURequestStepDate.js
• src/pages/iou/request/step/IOURequestStepCurrency.js
• src/pages/iou/request/step/IOURequestStepConfirmation.js
• src/pages/iou/request/step/IOURequestStepCategory.js
• src/pages/iou/request/step/IOURequestStepAmount.js

[DylanDylann]

IMO we should migrate all these files (there are no deprecated files in your list)

cc @tgolen

[fabioh8010]

Me again 👋 Just to confirm, these ones will be removed too, right?

• src/pages/iou/MoneyRequestMerchantPage.js
• src/pages/iou/steps/MoneyRequestConfirmPage.js
• src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js
• src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js
• src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

[DylanDylann]

@fabioh8010 These page will be removed soon. Let's ignore it

Cc @tgolen

[tgolen]

Weekly Update

• Looks like things are still in progress
• Half of the remaining issues are on HOLD for previous issues

Next Steps

• Continue working through these to get things unheld and cleaned up

ETA

• All done by May 1

[DylanDylann]

@tgolen This is an update on the current (Because I have followed these issues as both C role and C+ role for long time, I can help to summarise here)

Most issues have been merged except the following ones:

Reviewing PR

• Remove IOUCurrencySelection.js and copy any changes since Nov 27 into IOURequestStepCurrency.js
• Remove MoneyRequestParticipantsPage.js and copy any changes since Nov 27 into IOURequestStepParticipants.js

On Hold

• Remove MoneyRequestParticipantsSelector.js and copy any changes since Nov 27 into MoneyTemporaryForRefactorRequestParticipantsSelector

To speed up, I suggest we can handle Remove MoneyRequestParticipantsSelector.js and copy any changes since Nov 27 into MoneyTemporaryForRefactorRequestParticipantsSelector in Remove MoneyRequestParticipantsPage.js and copy any changes since Nov 27 into IOURequestStepParticipants.js

And we could open a new issue for this one: Remove MoneyRequestConfirmationList.js and copy any changes since Nov 27 into MoneeRequestConfirmationList.js

After the above is done, we can create an final issue to clean up the rest.

[tgolen]

OK. I think that plan makes sense. Do you need me to do anything? Maybe create the issue for MoneyRequestConfirmationList.js? I was holding off on that one mostly because it all of the other components are referenced inside that component, so it made sense to do it last.

A lot of the tasks that don't have issues created for them yet need to be re-evaluated. My plan was that once all the components were cleaned up, then the code would be in a better state to determine what exactly the remaining cleanup items would be.

[DylanDylann]

@tgolen I think we can process this one

Maybe create the issue for MoneyRequestConfirmationList.js

[tgolen]

Great! I created it and linked it.

[eh2077]

@tgolen I think we can process this one

Maybe create the issue for MoneyRequestConfirmationList.js

Coming from https://github.com/Expensify/App/issues/39559, can you help to explain what's relationship of MoneyRequestConfirmationList.js and MoneyTemporaryForRefactorRequestConfirmationList.js? Should we merge them before merging with IOURequestStepConfirmation?

cc @tgolen @DylanDylann

[DylanDylann]

As I understand, in https://github.com/Expensify/App/issues/39559 we need to remove MoneyRequestConfirmationList.js and copy any changes since Nov 27 into MoneyTemporaryForRefactorRequestConfirmationList.js

[tgolen]

Oh, man, I think I made a mistake in writing up that issue :D Thanks for pointing it out.

@DylanDylann is correct. I'll update the issue

[tgolen]

Weekly Update

• All component issues have been created and assigned and are being worked on

Next Steps

• Once all PRs are merged, @tgolen take a look around the remaining libs to see what remaining code is left to clean up

ETA

• Still on track to be done by May 1

[shubham1206agra]

remove "create" from the front of the routes

@tgolen You might want to update this as we are using the IOUAction in different parts of whisper track expense flow.

[DylanDylann]

@tgolen There is only this issue in the process (This is not a page, the change is minor), other issues were done. Currently, we can continue the next step to clean up the rest. If possible, I am happy to take over the clean-up task as contributor or contributor plus role

[brunovjk]

I would love to help as well