[$250] [TS migration] Migrate 'SettingsProfile' page to TypeScript

[melvin-bot[bot]]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/pages/settings/Profile/TimezoneSelectPage.js	13
src/pages/settings/Profile/TimezoneInitialPage.js	17
src/pages/settings/Profile/PronounsPage.js	15
src/pages/settings/Profile/ProfilePage.js	27
src/pages/settings/Profile/LoungeAccessPage.js	12
src/pages/settings/Profile/DisplayNamePage.js	19
src/pages/settings/Profile/CustomStatus/StatusSetPage.js	19
src/pages/settings/Profile/CustomStatus/StatusPage.js	22

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010a034a6d97b21d01
• Upwork Job ID: 1750845252939186176
• Last Price Increase: 2024-01-26
• Automatic offers:
• ntdiary | Reviewer | 28123436
• abzokhattab | Contributor | 28123437

[melvin-bot[bot]]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot[bot]]

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[aeioual]

Interested

[abzokhattab]

I can work on this

[s-alves10]

Dibs

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~010a034a6d97b21d01

[melvin-bot[bot]]

Triggered auto assignment to @trjExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[melvin-bot[bot]]

Upwork job price has been updated to $250

[melvin-bot[bot]]

📣 @ntdiary 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

📣 @abzokhattab 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[ghost]

Dibs

[aeioual]

@mountiny , i was the first one to comment on this issue :) here

[abzokhattab]

check this message @Amarparab2024

[melvin-bot[bot]]

@ntdiary, @trjExpensify, @abzokhattab Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[trjExpensify]

@abzokhattab when can we expect a PR?

[abzokhattab]

working on it

[abzokhattab]

There is some progress here the PR is draft because of the following issues:

1. this file has been deleted from the repo, so should I just drop it? https://github.com/Expensify/App/blob/main/src/pages/settings/Profile/CustomStatus/StatusSetPage.js
2. still having some issues in the StatusPage component will try to fix them again.

[SzymczakJ]

@abzokhattab @ntdiary how is work on this issue going?

[abzokhattab]

Thanks for the reminder .. the pr is currently in progress

[abzokhattab]

I am struggling a bit with resolving this type error inside the ref prop of the FormProvider

any ideas how to solve it ?

[ntdiary]

I am struggling a bit with resolving this type error inside the ref prop of the FormProvider any ideas how to solve it ?

Index: src/components/Form/FormProvider.tsx
-})(forwardRef(FormProvider)) as <TFormID extends OnyxFormKey>(props: Omit<FormProviderProps<TFormID>, keyof FormProviderOnyxProps>) => ReactNode;
+})(forwardRef(FormProvider)) as <TFormID extends OnyxFormKey>(props: Omit<FormProviderProps<TFormID> & RefAttributes<FormRef>, keyof FormProviderOnyxProps>) => ReactNode;

@abzokhattab, how about adding a RefAttributes?

[abzokhattab]

Thanks alot @ntdiary it did work

[blazejkustra]

@abzokhattab Please tag me once PR is ready for review

[blazejkustra]

@abzokhattab @ntdiary What is the status of this?

[ntdiary]

@abzokhattab @ntdiary What is the status of this?

Ah, I've tested and approved that PR #35446. :)

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.52-6 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/35446

If no regressions arise, payment will be issued on 2024-03-22. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @ntdiary requires payment automatic offer (Reviewer)
• @abzokhattab requires payment automatic offer (Contributor)

[melvin-bot[bot]]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@ntdiary] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [ ] [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[trjExpensify]

👋 confirming the payments here as follows:

• $250 to @ntdiary for the C+ review - paid
• $250 to @abzokhattab for the fix - offer sent

I've paid @abzokhattab. @ntdiary your offer expired, so I sent another one.