App icon indicating copy to clipboard operation
App copied to clipboard

[$250] [TS migration] Migrate 'NewTask' page to TypeScript

Open melvin-bot[bot] opened this issue 2 years ago • 14 comments

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/tasks/NewTaskTitlePage.js 18
src/pages/tasks/NewTaskPage.js 23
src/pages/tasks/NewTaskDetailsPage.js 18
src/pages/tasks/NewTaskDescriptionPage.js 18
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011d7e945e3d56a16e
  • Upwork Job ID: 1750844014325379072
  • Last Price Increase: 2024-01-26

melvin-bot[bot] avatar Aug 17 '23 11:08 melvin-bot[bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

melvin-bot[bot] avatar Sep 11 '23 07:09 melvin-bot[bot]

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

melvin-bot[bot] avatar Nov 23 '23 13:11 melvin-bot[bot]

Hi, I'm Kacper from Callstack - expert contributor group - and I would like to take a look at this issue.

fvlvte avatar Jan 24 '24 09:01 fvlvte

Job added to Upwork: https://www.upwork.com/jobs/~011d7e945e3d56a16e

melvin-bot[bot] avatar Jan 26 '24 11:01 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

melvin-bot[bot] avatar Jan 26 '24 11:01 melvin-bot[bot]

Dibs

ghost avatar Jan 26 '24 11:01 ghost

Upwork job price has been updated to $250

melvin-bot[bot] avatar Jan 26 '24 11:01 melvin-bot[bot]

Triggered auto assignment to @alexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

melvin-bot[bot] avatar Jan 26 '24 11:01 melvin-bot[bot]

Thank you, everyone, for the energy here, but please follow the contributor guidelines. If you are interested in this one, then please submit a proposal for the changes that are important here. After, it will go through a review process.

alexpensify avatar Jan 26 '24 18:01 alexpensify

Correction to my post from Friday. This one has been assigned to @fvlvte and they will work on a proposal this one.

alexpensify avatar Jan 29 '24 20:01 alexpensify

@fvlvte any update on how the update is going?

alexpensify avatar Feb 06 '24 00:02 alexpensify

No update

alexpensify avatar Feb 07 '24 23:02 alexpensify

Hey, sorry, missed notification I was on another task, ll open draft today @alexpensify

fvlvte avatar Feb 07 '24 23:02 fvlvte

All good, thank you!

alexpensify avatar Feb 07 '24 23:02 alexpensify

Weekly Update: @fvlvte any news here? Thanks!

alexpensify avatar Feb 13 '24 22:02 alexpensify

Hey, I got reassigned to another project so I think somebody from Callstack team will pick it over

fvlvte avatar Feb 14 '24 09:02 fvlvte

Hi, I'm Eugene from Callstack - an expert contributor group I’d like to work on this issue

pasyukevich avatar Feb 14 '24 10:02 pasyukevich

Hey @alexpensify I just finished another TS migration job and would like to handle this one now. Looks like it's still unassigned but please let me know.

Proposal:

I would review current functionality and determine where these files are imported or otherwise used (e.g. via Routing). Once I understand their use I would amend their filenames to TS or TSX (where applicable) and amend the code in all four files to TS. I would then test them on all platforms and ensure no errors or changes in functionality are taking place prior to submitting PR for review.

hkopser99 avatar Feb 19 '24 17:02 hkopser99

I'm catching up from being OOO and assigned @pasyukevich.

alexpensify avatar Feb 21 '24 01:02 alexpensify

I am planning to go OOO. Please reassign.

thesahindia avatar Feb 21 '24 16:02 thesahindia

I asked for C+ help here:

https://expensify.slack.com/archives/C02NK2DQWUX/p1709073195364429

alexpensify avatar Feb 27 '24 22:02 alexpensify

šŸ“£ @c3024 šŸŽ‰ An offer has been automatically sent to your Upwork account for the Contributor role šŸŽ‰ Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review šŸ§‘ā€šŸ’» Keep in mind: Code of Conduct | Contributing šŸ“–

melvin-bot[bot] avatar Feb 27 '24 22:02 melvin-bot[bot]

@c3024 will be stepping in as the C+ here. Thanks!

alexpensify avatar Feb 27 '24 22:02 alexpensify

@pasyukevich - Any update here? Thanks!

alexpensify avatar Mar 05 '24 22:03 alexpensify

@alexpensify PR was opened for review, waiting for a second review

pasyukevich avatar Mar 06 '24 12:03 pasyukevich

Awesome, thanks for the update.

alexpensify avatar Mar 06 '24 14:03 alexpensify

Thanks for the update, it looks like the review happened and we are moving forward here.

alexpensify avatar Mar 06 '24 18:03 alexpensify

Weekly Update: PR is in review

alexpensify avatar Mar 12 '24 21:03 alexpensify

Deployed to production. Automation hasn't triggered here.

c3024 avatar Mar 15 '24 11:03 c3024

This looks like it slipped my payment review process, I need to review this one more tomorrow since we might be past the 7-day mark.

alexpensify avatar Mar 25 '24 23:03 alexpensify