App
App copied to clipboard
Expensify
[TS migration] Migrate 'WorkspaceInvite' page to TypeScript
TypeScript migration
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files
| Path | Dependencies |
|---|---|
| src/pages/workspace/WorkspaceInvitePage.js | 25 |
| src/pages/workspace/WorkspaceInviteMessagePage.js | 28 |
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue has not been updated in over 15 days. eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.
Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.
@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.
Triggered auto assignment to @alexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.
Thanks for the update, looks like Viktoryia is going to work on this one.
Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
Job added to Upwork: https://www.upwork.com/jobs/~0172eb9572baef31c1
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)
@VickyStash said that they would work on it, I put the external label on so that we could get a C+ contributor and upwork automation going. @VickyStash feel free to put up a PR or let us know if you want someone else to work on it 🙂
I think there is PR already 🤔 https://github.com/Expensify/App/pull/35080
Ah, I missed that. I assumed since melvin had just assigned me that a PR hadn't already been put up. Looks like @hoangzinh is the C+ for this issue. My bad.
📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻 Keep in mind: Code of Conduct | Contributing 📖
@blimpich - should we unassign @VickyStash since it looks like you offering this one to @hoangzinh? Thanks for clarifying!
@alexpensify no that was a mistake, @hoangzinh is the C+ and @VickyStash is the contributor. I don't know why the automation didn't assign @hoangzinh as the reviewer first.
Reviewing label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.40-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
- https://github.com/Expensify/App/pull/35080
If no regressions arise, payment will be issued on 2024-02-20. :confetti_ball:
For reference, here are some details about the assignees on this issue:
- @hoangzinh requires payment automatic offer (Contributor) - $250
- @VickyStash does not require payment (Contractor)
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [ ] [@hoangzinh] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
- [ ] [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
I'm catching up from being OOO and will complete the payment process tomorrow. There is an issue with Upwork that I'm trying to figure out since it shows a Pending status for the payment to @hoangzinh.
@hoangzinh - do you see an option to accept the job in Upwork? I think you need to accept first. Thanks!
@alexpensify I couldn't see an option to accept the job but I just applied for the upwork job here https://github.com/Expensify/App/issues/25207#issuecomment-1934607274.
@hoangzinh - Upwork didn't flag that you applied so I withdrew the other offer. I resent one now. Let me know if you don't see the new one. Sorry for this back and forth but I hope this new offer works.
@hoangzinh - Done! You have been paid via Upwork. Thanks again for your patience here!