App icon indicating copy to clipboard operation
App copied to clipboard

[HOLD for payment 2024-02-07] [TS migration] Migrate 'ReportWelcomeMessage' page to TypeScript

Open melvin-bot[bot] opened this issue 1 year ago • 9 comments

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/ReportWelcomeMessagePage.js 22

melvin-bot[bot] avatar Aug 17 '23 11:08 melvin-bot[bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

melvin-bot[bot] avatar Sep 11 '23 07:09 melvin-bot[bot]

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

melvin-bot[bot] avatar Nov 23 '23 13:11 melvin-bot[bot]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

VickyStash avatar Jan 17 '24 14:01 VickyStash

Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] avatar Jan 25 '24 15:01 melvin-bot[bot]

Triggered auto assignment to @lschurr (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

melvin-bot[bot] avatar Jan 30 '24 12:01 melvin-bot[bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] avatar Jan 31 '24 22:01 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.34-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/34663

If no regressions arise, payment will be issued on 2024-02-07. :confetti_ball:

melvin-bot[bot] avatar Jan 31 '24 22:01 melvin-bot[bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [ ] [@Gonals] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [ ] [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

melvin-bot[bot] avatar Jan 31 '24 22:01 melvin-bot[bot]

Is there anyone who needs payment for this issue @Gonals? I think just @jjcoffee for reviewing the PR right?

lschurr avatar Feb 05 '24 22:02 lschurr

Is there anyone who needs payment for this issue @Gonals? I think just @jjcoffee for reviewing the PR right?

I think so, yep

Gonals avatar Feb 07 '24 14:02 Gonals

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

melvin-bot[bot] avatar Feb 07 '24 15:02 melvin-bot[bot]

Payment summary:

  • Contributor: @VickyStash is an agency-contributor and not due payment.
  • Contributor+: @jjcoffee $250 to be paid in Upwork

lschurr avatar Feb 07 '24 16:02 lschurr

Offer sent in Upwork @jjcoffee

lschurr avatar Feb 07 '24 16:02 lschurr

@lschurr Thanks, offer accepted!

jjcoffee avatar Feb 08 '24 11:02 jjcoffee

Payment sent in Upwork. Closing this one out.

lschurr avatar Feb 08 '24 16:02 lschurr