[HOLD for payment 2023-05-04] [$1000] Connect Bank - Tab button is not fully outlining the address box when the address is long

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR https://github.com/Expensify/App/pull/17403

Action Performed:

1. Access staging.new.expensify.com or Desktop app
2. Sign into a valid account
3. Go to Profile > Workspace > Connect bank account > connect manually > enter account and routing and click Continue
4. Insert any address that will return suggestions (Ex. 123 Street)
5. Tap tab several times

Expected Result:

User expects there to be a full blue outline on every suggested address

Actual Result:

On long suggestions, the blue box shows as incomplete on the right hand border

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [x] MacOS / Chrome / Safari
• [x] MacOS / Desktop

Version Number: 1.3.1.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/232896194-71fb99bf-e5f5-489e-83f5-30731a2950cf.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01eddd79237cf9a606
• Upwork Job ID: 1648739037202685952
• Last Price Increase: 2023-04-19

[MelvinBot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• [x] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [x] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [x] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [x] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [x] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[b-antonenko]

I didn't find this task on Upwork, but maybe my proposal here will be good and I'll get this or any other task from you.

Here we need to play with CSS of the div where the text is placed. One of the possible solutions can be to hide the overflow of the div and make text truncation. something like this in CSS:

div {
  ...some CSS; 
  overflow: hidden; 
  text-overflow: ellipsis; 
}

Of course, if this solution fits the design expectations.

[lschurr]

I was able to reproduce on Chrome.

[MelvinBot]

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[lschurr]

Shall we make this external @thienlnam?

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01eddd79237cf9a606

[MelvinBot]

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[MelvinBot]

Current assignee @thienlnam is eligible for the External assigner, not assigning anyone new.

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tab is outline to the overflowed content bcoz it is scrollable

What is the root cause of that problem?

Currently, the option is scrollable horizontally which takes full width of the available content. https://user-images.githubusercontent.com/14358475/233155825-f79074bc-9538-4cf6-8678-db17f265ac7f.mov

What changes do you think we should make in order to solve the problem?

We need to add prop isRowScrollable={false} for GooglePlacesAutocomplete which truncates text with ellipses and won't allow horizontal scrolling anymore for the options and also fixes the outline issue on the tab. https://github.com/Expensify/App/blob/da794230cf106ad11cab6b584f7f693cfcfcfc39/src/components/AddressSearch.js#L205

Result

https://user-images.githubusercontent.com/14358475/233155954-6fba2c7c-9ada-47ea-965e-e243b2202246.mov

[huzaifa-99]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We are trying to show the right side blue highlight of address option when focused via tab.

What is the root cause of that problem?

The options in AddressSearch can be scrolled horizontally which hides the right side blue border

What changes do you think we should make in order to solve the problem?

I think its design related and the expected result should be confirmed from the design team.

We could show the full address, maybe wrap it on next line by adding numberOfLines=3 (or more/less than 3) to the AddressSearch here along with isRowScrollable={false}

What alternative solutions did you explore? (Optional)

N/A

[situchan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

right outline border is hidden when address is long and highlighted by TAB

What is the root cause of that problem?

https://github.com/Expensify/react-native-google-places-autocomplete/blob/6f436a06a3018cb49750bb110b89df75f6a865d5/GooglePlacesAutocomplete.js#L637-L673

Highlight is coming from Pressable and ScrollView is inside Pressable so outline involves entire scrollable row

What changes do you think we should make in order to solve the problem?

Swap ScrollView and Pressable so that outline involves only visible view

https://user-images.githubusercontent.com/108292595/233840581-872ab08a-f98f-4665-9b46-1bf47cb08384.mov

[lschurr]

@aimane-chnaif can you review these proposals?

[aimane-chnaif]

All 3 proposals above work but depending on design choice, we can pick one up. @shawnborton can you please help review screenshots in proposals and provide feedback?

1. keep 1 line, disable horizontal scrolling and instead add ... at the end
2. multi lines, disable horizontal scrolling
3. keep 1 line, keep horizontal scrolling as is now but just make outline fixed

[shawnborton]

I think I like this proposal the best:

And then we should truncate after two lines with an ellipsis. But I feel like the address is pretty important and we shouldn't just truncate it after 1 line.

[aimane-chnaif]

Thanks @shawnborton

@thienlnam let's go with @huzaifa-99's proposal as it's the most close.

🎀 👀 🎀 C+ reviewed

[MelvinBot]

📣 @huzaifa-99 You have been assigned to this job by @lschurr! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[huzaifa-99]

Thank you for the review @aimane-chnaif @shawnborton @thienlnam. PR will be up in a short while

[huzaifa-99]

PR up for review https://github.com/Expensify/App/pull/17942. And also as @shawnborton had suggested here, I updated the code to truncate address after two lines with an ellipsis

cc: @aimane-chnaif @thienlnam

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.6-0 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/17942

If no regressions arise, payment will be issued on 2023-05-04. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter - N/A
• [x] Contributor that fixed the issue - @huzaifa-99
• [ ] Contributor+ that helped on the issue and/or PR - @aimane-chnaif

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [ ] [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[lschurr]

@aimane-chnaif and @huzaifa-99 can you apply for the job in Upwork? https://www.upwork.com/jobs/~01eddd79237cf9a606

[huzaifa-99]

@Ischurr Applied thanks

[huzaifa-99]

@Ischurr Am I eligible for the 3 day merge bouns?

[lschurr]

Yep! As long as there are no regressions before the payout date, a bonus will be applied @huzaifa-99

[lschurr]

@aimane-chnaif do we need a regression test for this one?

[aimane-chnaif]

@aimane-chnaif do we need a regression test for this one?

No PR caused regression. The issue was from library (actually not bug). Since this is minor style polish and kind of accessibility, no need regression test.

[lschurr]

All paid, going to close!