[$1000] Incorrect copy terminology in Add Bank Account Form

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings
3. Open workspaces
4. Open any workspace
5. Open connect bank account
6. Click on connect manually
7. Without filling any details, click on continue
8. Fill in details in step 1 and click on continue. eg details: routing no= 210021002, acc no= 1234
9. Without filling any field, click on Save & continue
10. Observe that for 'Incorporation state' field, even though field is dropdown, validation error says 'Please enter' in place of 'Please select'

Expected Result:

App should maintain consistent validation statements for fields in connect bank account

Actual Result:

App has many inconsistencies in validation statements for fields in connect bank account

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [x] MacOS / Chrome / Safari
• [ ] MacOS / Desktop

Version Number: 1.3.0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43996225/232615645-83ccb3df-c2fe-4834-9e2b-575320d5d5ec.mp4

https://user-images.githubusercontent.com/43996225/232615664-d3729eee-24dd-40b5-98af-a2b234a1c298.mp4

Expensify/Expensify Issue URL: Issue reported by: @dhanashree-sawant Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681660533308849

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013e01cb4925f3fd49
• Upwork Job ID: 1648701949863370752
• Last Price Increase: 2023-04-26

[MelvinBot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• [x] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [x] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [x] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [x] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [x] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[thienlnam]

@kavimuru Can you please consolidate all the capitalization issues into a single issue? Right now, I've been merging them into https://github.com/Expensify/App/issues/17239

[thienlnam]

Re-opening this issue because there is one problem which involves incorrect terminology which is not going to be taken care of in the capitalization issue

[flaviadefaria]

I'm not sure this is a bug. Posted in slack about it.

[flaviadefaria]

Oh, the recording got me confused as it highlighted another field. Moving it forward as a bug.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~013e01cb4925f3fd49

[MelvinBot]

Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect copy terminology of form error messages.

What is the root cause of that problem?

The translate literals in translation files are not correct i.e. it should be Please select ... instead of Please enter ... for drop-down fields.

What changes do you think we should make in order to solve the problem?

Find the drop-down fields in the form then inspect the translation file and make modification for those fields' error messages if necessary. Some of the lines have inconsistent capitalization format but they're being taken care of in https://github.com/Expensify/App/issues/17239. So I'll leave them as is and only make modification to match this issue's expectation. Here're incorrect lines that I've found so far:

https://github.com/Expensify/App/blob/59b3070b2c971e1317aed8bad96fd5c93ab2bb9d/src/languages/en.js#L731

https://github.com/Expensify/App/blob/59b3070b2c971e1317aed8bad96fd5c93ab2bb9d/src/languages/en.js#L736

Also in es.js:

https://github.com/Expensify/App/blob/59b3070b2c971e1317aed8bad96fd5c93ab2bb9d/src/languages/es.js#L730

https://github.com/Expensify/App/blob/59b3070b2c971e1317aed8bad96fd5c93ab2bb9d/src/languages/es.js#L735

What alternative solutions did you explore? (Optional)

NA

[MelvinBot]

Triggered auto assignment to @arosiclair (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[getusha]

Proposal

Please re-state the problem that we are trying to solve in this issue.

there are inconsistencies in validation sentences for fields in connect bank page.

What is the root cause of that problem?

There is inconsistency on validation statements where a picker also shows enter instead of select

What changes do you think we should make in order to solve the problem?

In order to make it consistent we can change the values of the validation statements as follows, including date picker which is present in Add Bank Account Form. for date pickers we can also use Please pick...

https://github.com/Expensify/App/blob/59b3070b2c971e1317aed8bad96fd5c93ab2bb9d/src/languages/en.js#L99 Please select a valid date

https://github.com/Expensify/App/blob/59b3070b2c971e1317aed8bad96fd5c93ab2bb9d/src/languages/en.js#L731 Please select a valid state

https://github.com/Expensify/App/blob/59b3070b2c971e1317aed8bad96fd5c93ab2bb9d/src/languages/en.js#L736 Please select a valid Company Type

(Optional) We should also update the following https://github.com/Expensify/App/blob/59b3070b2c971e1317aed8bad96fd5c93ab2bb9d/src/languages/en.js#L739

https://github.com/Expensify/App/blob/59b3070b2c971e1317aed8bad96fd5c93ab2bb9d/src/languages/en.js#L99

https://github.com/Expensify/App/blob/59b3070b2c971e1317aed8bad96fd5c93ab2bb9d/src/languages/en.js#L509

to reflect select instead of enter

What alternative solutions did you explore? (Optional)

None

[sharlenaluyen]

I believe the best Spanish translation to add a new company type would be, "Ingrese un tipo de empresa válido" This seems a bit more natural for Spanish speakers.

[MelvinBot]

📣 @sharlenaluyen! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[flaviadefaria]

@mananjadhav any thoughts on the proposals above?

[mananjadhav]

@flaviadefaria @arosiclair do we need to consider the date picker here? That's the only difference between both the proposals. If not, then let's use @tienifr's proposal else @getusha's.

[tienifr]

I don't think the date picker modification is necessary because you can manually type in a date.

[getusha]

I think the picker modification is necessary since the new Date Picker doesn't let users enter any date and we will be soon updating all pickers to use the new one. Also most of the time users tend to use the picker. and it makes sense to say pick a date or select a date.

[arosiclair]

I think "please select" is appropriate for both dropdowns and date picker fields.

[MelvinBot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mananjadhav]

@arosiclair Can you please finalize one of the proposal?

[arosiclair]

Let's hire @getusha since he also proposed updating the date picker text. I'll reach out internally to get Spanish translations

[MelvinBot]

📣 @getusha You have been assigned to this job by @arosiclair! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[getusha]

@arosiclair Should I wait for the translations or open a PR now?

[arosiclair]

You can submit your PR! We'll just update it when I get a response

[melvin-bot[bot]]

@mananjadhav, @arosiclair, @getusha, @flaviadefaria Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.12-0 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/18160

If no regressions arise, payment will be issued on 2023-05-16. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [x] [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [x] [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [x] [@mananjadhav] Determine if we should create a regression test for this bug.
• [x] [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mananjadhav]

These texts have been existing since a long time and not necessarily a bug. We definitely improved the context and I don't think we need a regression test here. what do you folks think @flaviadefaria @arosiclair ?