[$1000] Input doesn't keep focusing

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. open workspace -> connect manually -> go to first page of "company information"
2. Input any numbers and tap "Enter" from keyboard

Expected results:

Input should keep focusing

Actual results:

Input doesn't keep focusing

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [x] MacOS / Chrome / Safari
• [ ] MacOS / Desktop

Version Number: 1.3.0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

screen-capture.webm

https://user-images.githubusercontent.com/43996225/232606810-9f7ee7a4-8c98-4622-b320-b34e0ff18d4d.mp4

Expensify/Expensify Issue URL: Issue reported by: @MahmudjonToraqulov Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681361020250409

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0132929684257a053c
• Upwork Job ID: 1650632490420547584
• Last Price Increase: 2023-04-24

[MelvinBot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[adelekennedy]

I think this issue is related to #15992 @bondydaa should I put this on hold and add to the tracking issue?

[bondydaa]

No I don't think so, https://github.com/Expensify/App/issues/15992 is specificly about the compose component which is the main text box you type in to for chats. this has to do with an input on a different component and is it's own thing.

[MelvinBot]

@adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0132929684257a053c

[MelvinBot]

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.

[adelekennedy]

Moving to External!

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[MelvinBot]

Triggered auto assignment to @grgia (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Input doesn't keep focusing when press enter key

What is the root cause of that problem?

By default, when we press enter key in a input field, it will submit the form. In react-native, it sets blurOnSubmit to true by default https://reactnative.dev/docs/textinput#bluronsubmit

=> That is the root cause why submit form, the input will be blur

What changes do you think we should make in order to solve the problem?

We can easily fix by set blurOnSubmit prop of those TextInput to false in those LOC

[parasharrajat]

I don't feel strongly to change this. What do you think about it @grgia?

[parasharrajat]

@MahmudjonToraqulov This part is documented in the contributing guidelines https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#proposing-a-job-that-expensify-hasnt-posted points 8 and 9.

In short, when this issue is solved, you will be paid reporting bonus as well. If this issue is not solved or closed, then there will not be any payment for reporting.

[adelekennedy]

@grgia @parasharrajat looking back at this I don't feel that strongly that this is a real problem, any opinions if we should move forward with it or close for now?

[parasharrajat]

I asked the same question https://github.com/Expensify/App/issues/17534#issuecomment-1520965563

[kuluruvineeth]

@adelekennedy

Proposal - 2 What changes do you think we should make in order to solve the problem?

• There are two text inputs in this form one for routing number and other for account number.
• I would create reference for the second text input so on pressing enter on the first text field, i would shift focus to second text field.
• In the second text field on pressing enter would focus on itself by setting blurOnSubmit to false.
• These points would resolve and cater to our needs.

[grgia]

@adelekennedy @parasharrajat I agree, we can do nothing. Closing now! Feel free to reopen if you changed your mind