App icon indicating copy to clipboard operation
App copied to clipboard

Large attachment upload blocks group chat messages from other senders

Open kavimuru opened this issue 1 year ago • 16 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Create a group with few members
  2. Send a large file attachment (20 MB size) from account A to the group
  3. While the attachment is uploading, send multiple messages from account B to the group
  4. On account A, go back from the group chat and open another chat
  5. When the attachment upload is done, check the group chat on account A

Expected Result:

The messages sent by account B should be displayed on account A’s group chat feed even if the attachment upload is not done. If account A opens another chat while uploading an attachment, the group chat should show an unread status indicator if new messages are sent by other accounts in the group.

Actual Result:

The messages sent by account B are not displayed on account A’s group chat feed until the attachment upload is done. If account A opens another chat while uploading an attachment, the group chat does not show an unread status indicator even if new messages are sent by other accounts in the group. The messages appear only after account A opens the group chat again.

Additional Note: On Android devices, account A can receive new messages from account B in the group chat, but the unread status indicator is not displayed on the group chat.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [x] Android / native
  • [ ] Android / Chrome
  • [ ] iOS / native
  • [ ] iOS / Safari
  • [x] MacOS / Chrome / Safari
  • [ ] MacOS / Desktop

Version Number: 1.3.0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43996225/231802218-887d67cb-c794-4f7e-8298-f32242838695.mp4

https://user-images.githubusercontent.com/43996225/231802243-4c6358e1-603f-4879-89f2-08b79e6336d6.mp4

Expensify/Expensify Issue URL: Issue reported by: @nathan-mulugeta Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681292087572289

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f2cd61da9c999f71
  • Upwork Job ID: 1648725726734278656
  • Last Price Increase: 2023-04-19

kavimuru avatar Apr 13 '23 15:04 kavimuru

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

MelvinBot avatar Apr 13 '23 15:04 MelvinBot

Bug0 Triage Checklist (Main S/O)

  • [x] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • [x] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • [x] This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • [x] This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • [x] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

MelvinBot avatar Apr 13 '23 15:04 MelvinBot

@michaelhaxhiu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

MelvinBot avatar Apr 17 '23 10:04 MelvinBot

@michaelhaxhiu Eep! 4 days overdue now. Issues have feelings too...

MelvinBot avatar Apr 19 '23 10:04 MelvinBot

testing

michaelhaxhiu avatar Apr 19 '23 13:04 michaelhaxhiu

This is likely highly related I think - https://github.com/Expensify/App/issues/17373

michaelhaxhiu avatar Apr 19 '23 15:04 michaelhaxhiu

Ok I reproduced this after a little tinkering. Used the same attachment as @nathan-mulugeta here

michaelhaxhiu avatar Apr 19 '23 16:04 michaelhaxhiu

I have a feeling this one is internal. But feel free to change if I'm wrong!

michaelhaxhiu avatar Apr 19 '23 16:04 michaelhaxhiu

Job added to Upwork: https://www.upwork.com/jobs/~01f2cd61da9c999f71

MelvinBot avatar Apr 19 '23 16:04 MelvinBot

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

MelvinBot avatar Apr 19 '23 16:04 MelvinBot

@michaelhaxhiu, @thesahindia Huh... This is 4 days overdue. Who can take care of this?

MelvinBot avatar Apr 25 '23 10:04 MelvinBot

@thesahindia or @jasperhuangg do you agree that this one is internal? Or could it be possibly external?

michaelhaxhiu avatar Apr 26 '23 02:04 michaelhaxhiu

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

MelvinBot avatar Apr 26 '23 02:04 MelvinBot

@michaelhaxhiu @jasperhuangg @thesahindia this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

MelvinBot avatar Apr 27 '23 10:04 MelvinBot

@thesahindia or @jasperhuangg do you agree that this one is internal? Or could it be possibly external?

Looks like a backend issue so yes it should be internal.

thesahindia avatar Apr 27 '23 12:04 thesahindia

I'm struggling to reproduce this because of Pusher errors that are happening due to our latest deploy. I'll take another look when things are back to normal

jasperhuangg avatar May 02 '23 20:05 jasperhuangg

@michaelhaxhiu @jasperhuangg @thesahindia this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

MelvinBot avatar May 04 '23 20:05 MelvinBot

I'm still holding off on looking at this issue because of the API errors that we've been having on staging and production lately.

jasperhuangg avatar May 05 '23 17:05 jasperhuangg

Hoping to look into this this week, swamped with other priorities that seem more important than this edge-casey issue.

jasperhuangg avatar May 08 '23 18:05 jasperhuangg

Still on HOLD

jasperhuangg avatar May 10 '23 21:05 jasperhuangg

@jasperhuangg as a reminder, for internal bugs we should ideally have the engineer find a volunteer to take it over if they need to unassign (rather than just unassigning). Did you have a chance to solicit a volunteer internally (e.g. in #engineering-chat)

michaelhaxhiu avatar May 25 '23 21:05 michaelhaxhiu

I posted internally here - https://expensify.slack.com/archives/C03TQ48KC/p1685050375117329

michaelhaxhiu avatar May 25 '23 21:05 michaelhaxhiu

I'm gonna have time to look into this this week.

youssef-lr avatar Jun 06 '23 01:06 youssef-lr

Fantastic, I'll provide a small nudge if it slips off your radar 🙏

michaelhaxhiu avatar Jun 07 '23 15:06 michaelhaxhiu

Lil nudge :) DM'ed Youssef too.

michaelhaxhiu avatar Jun 16 '23 18:06 michaelhaxhiu

I haven't managed to get to this yet. I will do my best to get to it this week.

youssef-lr avatar Jun 26 '23 10:06 youssef-lr

Currently focused on porting single level control policies to newDot as part of the Teachers Unite project, I will probably have time for this starting next week.

youssef-lr avatar Jul 05 '23 18:07 youssef-lr

Discussing the issue here.

youssef-lr avatar Jul 05 '23 22:07 youssef-lr

Closing as per the discussion above.

youssef-lr avatar Jul 06 '23 20:07 youssef-lr