App
App copied to clipboard
Expensify
[$1000] There is a delay of 1-2 seconds when a new workspace is created in the Android app.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
- Open the "Settings" of the app.
- Tap on "Workspaces".
- Select "New workspace". Notice the app almost freezes when the "New workspace" button is pressed for couple of seconds.
Expected Result
There should not be any delay, and the app should function smoothly like web.
Actual Result
The app freezes or experiences a delay of 1-2 seconds when the "New workspace" button is pressed.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [x] Android / native
Offline and Online - [x] Android / Chrome
Offline and Online - [x] iOS / native
Offline and Online - [x] iOS / Safari Offline and Online
- [x] MacOS / Chrome / Safari
Offline and Online - [x] MacOS / Desktop
Offline and Online
Version Number: 1.2.94-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43996225/229895085-7d308e86-cfac-4fd2-add0-75177d0c238f.mp4
https://user-images.githubusercontent.com/43996225/229895377-88435974-047b-4a15-a0e0-60efb547e4d8.mp4
Expensify/Expensify Issue URL: Issue reported by: @usmantariq96 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680610152510499
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0174b5420e1b80f716
- Upwork Job ID: 1645860223341436928
- Last Price Increase: 2023-04-11
Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
Bug0 Triage Checklist (Main S/O)
- [ ] This "bug" occurs on a supported platform (ensure
Platformsin OP are ✅) - [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
- [ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
- [ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
- [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
@usmantariq96 I tested this on a pixel 6 pro, and my delay isn't as slow as in your video. I agree there is a 0.5 second delay, and not as quick as web, but I wonder if hardware matters here?
📣 @usmantariq96! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:
- Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
- Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
- Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
I can replicate this in all our platforms some of the platforms have less of a delay than others (from what I can generally tell). I wonder if this is an expected behaviour. Asking the team here - 291788
Puneet mentioned this might be part of a bigger API command update. Not sure if this should be closed in favour of a different GH
cc @iwiznia @flodnv
@NicMendonca, @Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Based on this convo - https://expensify.slack.com/archives/C049HHMV9SM/p1681225595834389?thread_ts=1680610152.510499&cid=C049HHMV9SM
Testing this offline has the same delayed behaviour when creating a workspace. So going to add the external label for some help on this.
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue. cc @thienlnam
Current assignees @NicMendonca and @Christinadobrzyn are eligible for the External assigner, not assigning anyone new.
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)
Triggered auto assignment to @marcochavezf (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.
Current assignees @NicMendonca and @Christinadobrzyn are eligible for the External assigner, not assigning anyone new.
Current assignee @thesahindia is eligible for the External assigner, not assigning anyone new.
Current assignee @marcochavezf is eligible for the External assigner, not assigning anyone new.
Hi, I'm Olimpia from Callstack - expert contributor group - I'll be happy to work on this issue.
📣 @OlimpiaZurek You have been assigned to this job by @mountiny! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻 Keep in mind: Code of Conduct | Contributing 📖
Update: I started investigating this issue today. I did some performance profiling and found some possible improvements to speed things up. I will continue tomorrow.
@marcochavezf, @OlimpiaZurek, @NicMendonca, @Christinadobrzyn, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!
@marcochavezf @OlimpiaZurek @NicMendonca @Christinadobrzyn @thesahindia this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Update: I found the root cause of this issue. Basically the problem is that creating a new workspace on button press requires a lot of calculations under the hood and causes unnecessary re-rendering to other components. I am testing a possible solutions to fix it.
Update: I'm finalizing the proposal . I will post it on Monday as tomorrow we are having Upskilling Day, which means my Team and I will not be working on the project.
@marcochavezf, @OlimpiaZurek, @NicMendonca, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!
Proposal
Please re-state the problem that we are trying to solve in this issue.
The app freezes for a few seconds after pressing the "New Workspace" button.
What is the root cause of that problem?
When a new workspace is being created, the Policy.createWorkspace() function is invoked, leading to the execution of two functions: SidebarUtils.getOrderedReportIDs() and SidebarUtils.getOptionData(). These functions are essential for rendering the options within the <OptionRowLHN /> component, which is utilized by the <SidebarLinks /> component. Consequently, the <OptionRowLHN /> and <SidebarLinks /> components need to be re-rendered, which results in a slight delay when clicking on the "New workspace" button.
What changes do you think we should make in order to solve the problem?
When a user clicks the “New workspace” button in the context of a <Flatlist />, the app must perform several operations, including updating the list data, re-rendering the list view, and possibly performing additional layout calculations. These operations can be particularly taxing on older and slower devices that have limited processing power and memory.
Several performance improvements should be made to address this issue and make the click button work faster. First of all, I would suggest replacing FlatList with FlashList. Thanks to this, the items with <OptionRowLHN /> will render faster and smoother, and we will avoid long delays during clicking “New workspaces” button.
Also to prevent unnecessary re-rendering, I would suggest adding the React.memo and React.useMemo HOCs to the components consumed by <OptionRowLHN /> and <SidebarLinks />. By reducing the number of re-renderings, we can improve the overall performance of the sidebar screen and provide a smoother user experience.
Performance when creating new workspace without Components improvements:
As you can see in the screenshots below, using FlashList can reduce the number of re-renderings and most importantly reduce the rendering time of each element.
Performance when creating new workspace without Components improvements:
What alternative solutions did you explore? (Optional)
Additionally, I would suggest refactoring these two methods SidebarUtils.getOrderedReportIDs() and SidebarUtils.getOptionData(). There seem to be relatively large and complex functions, and they have a lot of logic. I would consider simplifying the logic by breaking the functions into smaller, more manageable functions.
@marcochavezf @OlimpiaZurek @NicMendonca @thesahindia this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!