Renaming chat room does not close RHP

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open a user-created policy room
2. Click on the name in the header
3. Click on Settings
4. Change the room name
5. Click save

Expected Result:

The room name should be updated and the settings modal should close.

Actual result:

The room name updates but the settings modal does not close.

Same behavior with workspace > general settings and notification preference input

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [x] MacOS / Chrome / Safari
• [ ] MacOS / Desktop

Version Number: 1.2.92-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43996225/228931834-c4e39749-c79a-4690-9201-825d174ae5bc.mp4

Expensify/Expensify Issue URL: Issue reported by: @roryabraham Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678551138542469

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b8598111904371a5
• Upwork Job ID: 1642887626659647488
• Last Price Increase: 2023-04-03

[MelvinBot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• [x] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [x] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [x] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [x] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [x] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@michaelhaxhiu Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Gonals]

Seems like a quick fix! Taking a look!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01b8598111904371a5

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

[Gonals]

Removing C+, as it is a very minor change!

[MelvinBot]

@michaelhaxhiu, @Gonals Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

@michaelhaxhiu, @Gonals Huh... This is 4 days overdue. Who can take care of this?

[Gonals]

In review!

[neil-marcellini]

Taking over while Alberto's gone.

[MelvinBot]

@michaelhaxhiu, @Gonals, @neil-marcellini 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[neil-marcellini]

I meant to get to this yesterday. I'll definitely work on it today.

[neil-marcellini]

I got the NotificationPreferencePage dialed in this evening. I'll keep working on this tomorrow.

[neil-marcellini]

I didn't get to this today because I was battling with Travis CI for another PR that's been open for a while.

[MelvinBot]

@michaelhaxhiu @Gonals @neil-marcellini this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

[neil-marcellini]

I'm not sure this is actually a WAQ bug, it feels like polish or even a new feature. What do you think @michaelhaxhiu? Regardless, I'll work on it today and try to finish it off ASAP.

[neil-marcellini]

I think I have everything done, but I still need to write some more detailed test steps and then record videos.

[michaelhaxhiu]

Just responding to your comment @neil-marcellini - I think this is an inconsistency and worth fixing, which was touched on in the OG slack thread. I'm glad you are close!

[neil-marcellini]

Ok, now this is actually under review.

[melvin-bot[bot]]

@michaelhaxhiu, @Gonals, @neil-marcellini Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[neil-marcellini]

I need to make a small change to the PR based on review feedback. Higher priority issues and PR reviews have come first. Maybe Alberto will be back soon lol

[neil-marcellini]

I'm going to be OOO until Monday fyi. I'll try to find someone to take this over while I'm out.

[neil-marcellini]

Looks like we're all busy and no one picked it up. I'm back. I didn't have time for this today, many PR reviews. Hopefully tomorrow.

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.16-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/16910

If no regressions arise, payment will be issued on 2023-05-29. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [x] [@Gonals / @neil-marcellini] The PR that introduced the bug has been identified. Link to the PR: N/A UI refactor
• [x] [@Gonals / @neil-marcellini] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A UI refactor
• [x] [@Gonals / @neil-marcellini] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A UI refactor
• [x] [@Gonals / @neil-marcellini] Determine if we should create a regression test for this bug. N/A UI refactor
• [x] [@Gonals / @neil-marcellini] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [x] [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[michaelhaxhiu]

Question - should we be paying @aimane-chnaif for C+ review of the PR? cc @neil-marcellini for bud check :)

[neil-marcellini]

Yes! @aimane-chnaif did a wonderful job reviewing.

[michaelhaxhiu]

invited to job - https://www.upwork.com/jobs/~01c2d7197fc8a993a4