App icon indicating copy to clipboard operation
App copied to clipboard

[HOLD for payment 2023-04-24] [$250] Migrate ReportActionsList.js to function component

Open marcaaron opened this issue 1 year ago • 10 comments

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes

marcaaron avatar Mar 20 '23 15:03 marcaaron

@marcaaron taking this issue off HOLD as per this Slack post

IMPORTANT: If anything unexpected pops up during the refactor/review:

  • [x] Take it to #expensify-open-source to get clarification on.
  • [x] Prefix the conversation with [HOOK REFACTOR] so that we can find it easily.
  • [x] Link the result of the conversation in this section of the Design Doc titled “Best Practices Conversations
  • [x] Add it to the STYLE.md guide in this open PR so we can reference it and apply any teachings in the next phase

marcaaron avatar Apr 05 '23 15:04 marcaaron

@marcaaron Please assign me here and a BZ member for payment processing.

s77rt avatar Apr 13 '23 03:04 s77rt

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

MelvinBot avatar Apr 13 '23 21:04 MelvinBot

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

marcaaron avatar Apr 13 '23 21:04 marcaaron

Reviewing label has been removed, please complete the "BugZero Checklist".

MelvinBot avatar Apr 17 '23 22:04 MelvinBot

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.0-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/16613

If no regressions arise, payment will be issued on 2023-04-24. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • [x] External issue reporter
  • [x] Contributor that fixed the issue
  • [ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

MelvinBot avatar Apr 17 '23 22:04 MelvinBot

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

MelvinBot avatar Apr 20 '23 19:04 MelvinBot

Bug0 Triage Checklist (Main S/O)

  • [x] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • [x] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • [x] This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • [x] This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • [x] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

MelvinBot avatar Apr 20 '23 19:04 MelvinBot

@greg-schroeder Added the bug label to get a BZ team member assigned. This isn't a "bug" per se, but part of an internal cleanup. We just need payment for @s77rt 🙇

marcaaron avatar Apr 24 '23 17:04 marcaaron

@greg-schroeder bump 🙏

marcaaron avatar Apr 27 '23 17:04 marcaaron

Sorry about that, taking care of payment

greg-schroeder avatar Apr 27 '23 18:04 greg-schroeder

Sent offer @s77rt

greg-schroeder avatar Apr 27 '23 18:04 greg-schroeder

@greg-schroeder Accepted

s77rt avatar Apr 27 '23 21:04 s77rt

Done!

greg-schroeder avatar Apr 27 '23 22:04 greg-schroeder